Skip to content

fix: build error on Apple Silicon due to ambiguous call to svwhilelt functions #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zebrapurring wants to merge 2 commits into from
Closed

fix: build error on Apple Silicon due to ambiguous call to svwhilelt functions #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52136f4
fix: build error on Apple Silicon due to ambiguous call to `svwhilelt…
May 24, 2025
fee45f6
fix: undefined symbols while linking on macOS for arm64
May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
[env]
CC = "clang"

[target.'cfg(target_os="macos")']
rustflags = ["-Clink-arg=-Wl,-undefined,dynamic_lookup"]
16 changes: 8 additions & 8 deletions crates/simd/cshim/aarch64.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ fp16_reduce_sum_of_xy_a2_fp16(f16 *restrict a, f16 *restrict b, size_t n) {
__attribute__((target("+sve"))) float
fp16_reduce_sum_of_xy_a3_512(f16 *restrict a, f16 *restrict b, size_t n) {
svfloat16_t xy = svdup_f16(0.0);
for (size_t i = 0; i < n; i += svcnth()) {
for (uint64_t i = 0; i < n; i += svcnth()) {
svbool_t mask = svwhilelt_b16(i, n);
svfloat16_t x = svld1_f16(mask, a + i);
svfloat16_t y = svld1_f16(mask, b + i);
Expand Down Expand Up @@ -153,7 +153,7 @@ fp16_reduce_sum_of_d2_a2_fp16(f16 *restrict a, f16 *restrict b, size_t n) {
__attribute__((target("+sve"))) float
fp16_reduce_sum_of_d2_a3_512(f16 *restrict a, f16 *restrict b, size_t n) {
svfloat16_t d2 = svdup_f16(0.0);
for (size_t i = 0; i < n; i += svcnth()) {
for (uint64_t i = 0; i < n; i += svcnth()) {
svbool_t mask = svwhilelt_b16(i, n);
svfloat16_t x = svld1_f16(mask, a + i);
svfloat16_t y = svld1_f16(mask, b + i);
Expand All @@ -166,7 +166,7 @@ fp16_reduce_sum_of_d2_a3_512(f16 *restrict a, f16 *restrict b, size_t n) {
__attribute__((target("+sve"))) float
fp32_reduce_sum_of_x_a3_256(float *restrict this, size_t n) {
svfloat32_t sum = svdup_f32(0.0);
for (size_t i = 0; i < n; i += svcntw()) {
for (uint64_t i = 0; i < n; i += svcntw()) {
svbool_t mask = svwhilelt_b32(i, n);
svfloat32_t x = svld1_f32(mask, this + i);
sum = svadd_f32_x(mask, sum, x);
Expand All @@ -177,7 +177,7 @@ fp32_reduce_sum_of_x_a3_256(float *restrict this, size_t n) {
__attribute__((target("+sve"))) float
fp32_reduce_sum_of_abs_x_a3_256(float *restrict this, size_t n) {
svfloat32_t sum = svdup_f32(0.0);
for (size_t i = 0; i < n; i += svcntw()) {
for (uint64_t i = 0; i < n; i += svcntw()) {
svbool_t mask = svwhilelt_b32(i, n);
svfloat32_t x = svld1_f32(mask, this + i);
sum = svadd_f32_x(mask, sum, svabs_f32_x(mask, x));
Expand All @@ -188,7 +188,7 @@ fp32_reduce_sum_of_abs_x_a3_256(float *restrict this, size_t n) {
__attribute__((target("+sve"))) float
fp32_reduce_sum_of_x2_a3_256(float *restrict this, size_t n) {
svfloat32_t sum = svdup_f32(0.0);
for (size_t i = 0; i < n; i += svcntw()) {
for (uint64_t i = 0; i < n; i += svcntw()) {
svbool_t mask = svwhilelt_b32(i, n);
svfloat32_t x = svld1_f32(mask, this + i);
sum = svmla_f32_x(mask, sum, x, x);
Expand All @@ -201,7 +201,7 @@ fp32_reduce_min_max_of_x_a3_256(float *restrict this, size_t n, float *out_min,
float *out_max) {
svfloat32_t min = svdup_f32(1.0 / 0.0);
svfloat32_t max = svdup_f32(-1.0 / 0.0);
for (size_t i = 0; i < n; i += svcntw()) {
for (uint64_t i = 0; i < n; i += svcntw()) {
svbool_t mask = svwhilelt_b32(i, n);
svfloat32_t x = svld1_f32(mask, this + i);
min = svmin_f32_x(mask, min, x);
Expand All @@ -215,7 +215,7 @@ __attribute__((target("+sve"))) float
fp32_reduce_sum_of_xy_a3_256(float *restrict lhs, float *restrict rhs,
size_t n) {
svfloat32_t sum = svdup_f32(0.0);
for (size_t i = 0; i < n; i += svcntw()) {
for (uint64_t i = 0; i < n; i += svcntw()) {
svbool_t mask = svwhilelt_b32(i, n);
svfloat32_t x = svld1_f32(mask, lhs + i);
svfloat32_t y = svld1_f32(mask, rhs + i);
Expand All @@ -228,7 +228,7 @@ __attribute__((target("+sve"))) float
fp32_reduce_sum_of_d2_a3_256(float *restrict lhs, float *restrict rhs,
size_t n) {
svfloat32_t sum = svdup_f32(0.0);
for (size_t i = 0; i < n; i += svcntw()) {
for (uint64_t i = 0; i < n; i += svcntw()) {
svbool_t mask = svwhilelt_b32(i, n);
svfloat32_t x = svld1_f32(mask, lhs + i);
svfloat32_t y = svld1_f32(mask, rhs + i);
Expand Down
Loading