Skip to content

Fix ValidatorIterator serialization #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ndtretyak
Copy link
Contributor

What was changed

to_jsonable_python is now used instead of default=str to serialize pydantic models.

Why?

Without this change ValidatorIterator is serialized as "ValidatorIterator(...)"

Checklist

  1. Closes

  2. How was this tested:

Unit tests

  1. Any docs updates needed?

@ndtretyak ndtretyak requested a review from a team as a code owner July 1, 2025 07:57
@tconley1428
Copy link
Contributor

@ndtretyak if you would like to resolve the merge conflicts and linting issues (See the readme or poe lint), then we can take the PR. Otherwise I can take the changes in and fix them, but your name will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants