Skip to content

Add update info to MDC context #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2024
Merged

Add update info to MDC context #2259

merged 1 commit into from
Oct 8, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Add update info to MDC context

closes: #2237

@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner October 8, 2024 01:21
cretz
cretz reviewed Oct 8, 2024
View reviewed changes
temporal-sdk/src/main/java/io/temporal/internal/sync/SyncWorkflow.java
Comment on lines +171 to +172
MDC.put(LoggerTag.UPDATE_ID, updateInfo.getUpdateId());
MDC.put(LoggerTag.UPDATE_NAME, updateInfo.getUpdateName());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm MDC is reset on workflow threads before they are reused?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdk-java/temporal-sdk/src/main/java/io/temporal/internal/sync/WorkflowThreadImpl.java

Line 127 in 089bbea

MDC.clear();

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit d1dc2e1 into temporalio:master Oct 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show update handler and ID in logging context
2 participants
@Quinn-With-Two-Ns @cretz