Added recommendations around worker versioning default options #3784
Conversation
| @@ -210,11 +210,9 @@ worker = Temporalio::Worker.new( | |||
|
|
|||
| ### Which Default Versioning Behavior should you choose? | |||
|
|
|||
| If you are using blue-green deployments, you should default to Auto-Upgrade and should not use Workflow Pinning. | |||
| In general, each Workflow Type should be annotated as Auto-Upgrade or Pinned. If you are using blue-green deployments and you expect your Workflow to run longer than your builds will exist, you should default to Auto-Upgrade and should not use Workflow Pinning. These Auto-Upgrade Workflows will still need to be [patched](https://docs.temporal.io/patching#patching). | |||
There was a problem hiding this comment.
I think there may be crossed wires here.
This section is referring to the worker's global default versioning behavior across many workflow types.
Whereas the new text seems to be talking about what to do for an individual workflow.
The section at line 77 is probably where we should first talk about the litmus test between short- and long-running workflows.
One suggestion is to link out to the encyclopedia entry for workflow and put the litmus test there.
There was a problem hiding this comment.
Thanks for clearing that up @drewhoskins-temporal. I shuffled the explanation around a bit. Do you think the changes here make more sense? https://github.com/temporalio/documentation/pull/3784/files#diff-80df3d3826730d03d3b4ebbc408c6c37f42f0851fb459f29dbca6d030dd65f78R81
flippedcoder
force-pushed
the
update/worker-versioning-recommendations
branch
from
c7c63be to
bd3b7b9
Compare
What does this PR do?
This adds more nuance around when to choose a Workflow Type to address #3730
Notes to reviewers