fix: FPU state corruption[port 0.8] #2461
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizhanovsky
requested review from
EvgeniiMekhanik
and removed request for
krizhanovsky
EvgeniiMekhanik
approved these changes
Jul 16, 2025
Store fpu context only when BH has been disabled and restore before enabling BH. Otherwise we may have dobule call of `kernel_fpu_begin()`, it may happens in following case: ``` 1) kernel_fpu_begin(); 2) local_bh_disable(); 3) do_something(); 4) local_bh_enable(); 5) kernel_fpu_end(); ``` In line (4) `local_bh_enable()` may call softIRQ handler that will call `kernel_fpu_begin()` before calling paired `kernel_fpu_end()` in line (5).
const-t
force-pushed
the
kt-fpu-fix-port-0.8
branch
from
37ab287 to
7318cfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store fpu context only when BH has been disabled and restore before enabling BH. Otherwise we may have
dobule call of
kernel_fpu_begin(), it may happens in following case:In line (4)
local_bh_enable()may call softIRQhandler that will call
kernel_fpu_begin()before calling pairedkernel_fpu_end()in line (5).