Skip to content

Task/remove old mongodb env vars#1767

Merged
fgalan merged 18 commits intomasterfrom
task/remove_old_mongodb_env_vars
Mar 27, 2026
Merged

Task/remove old mongodb env vars#1767
fgalan merged 18 commits intomasterfrom
task/remove_old_mongodb_env_vars

Conversation

@AlvaroVega
Copy link
Copy Markdown
Member

@AlvaroVega AlvaroVega commented Mar 26, 2026

related with #1766 (comment)

Since iota-node-lib 4.11 all IOTA_MONGO_XXX options except IOTA_MONGO_URI are deprecated:

Deprecated: IOTA_MONGO_ different from IOTA_MONGO_URI (use IOTA_MONGO_URI instead)
And soon will be removed

@AlvaroVega AlvaroVega marked this pull request as ready for review March 26, 2026 13:57
@AlvaroVega AlvaroVega requested a review from fgalan March 26, 2026 13:59
Comment on lines +165 to +173
// process.env.IOTA_MONGO_HOST = 'mongohost';
// process.env.IOTA_MONGO_PORT = '5555';
// process.env.IOTA_MONGO_DB = 'themongodb';
// process.env.IOTA_MONGO_REPLICASET = 'customReplica';
// process.env.IOTA_MONGO_USER = 'customUser';
// process.env.IOTA_MONGO_PASSWORD = 'customPassword';
// process.env.IOTA_MONGO_AUTH_SOURCE = 'customAuthSource';
// process.env.IOTA_MONGO_RETRIES = '10';
// process.env.IOTA_MONGO_RETRY_TIME = '5';
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover comments?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 69d6b07

@fgalan
Copy link
Copy Markdown
Member

fgalan commented Mar 26, 2026

Have a look to https://github.com/telefonicaid/iotagent-node-lib/blob/master/doc/deprecated.md

Config mongodb.* different from mongodb.uri (and associated env vars IOTA_MONGO_* except IOTA_MONGO_URI) in 4.11.0

to

Config mongodb.* different from mongodb.uri (and associated env vars IOTA_MONGO_* except IOTA_MONGO_URI) in 4.11.0 (finally removed in 4.14.0)

In addition many "Not yet" in the table below should use 4.13.0

AlvaroVega and others added 3 commits March 27, 2026 08:02
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
Comment on lines +53 to +55
// host: 'localhost',
// port: '27017',
// db: 'iotagent'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover comments?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 13f8306

Comment on lines +94 to +96
// host: 'localhost',
// port: '27017',
// db: 'iotagent'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover comments?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 13f8306

Comment on lines +53 to +55
// host: 'localhost',
// port: '27017',
// db: 'iotagent'
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover comments?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 13f8306

Copy link
Copy Markdown
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 1e86aaf into master Mar 27, 2026
12 checks passed
@fgalan fgalan deleted the task/remove_old_mongodb_env_vars branch March 27, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants