fix(pipelinerun): add missing sort logic for childRefs array#9356
Closed
vdemeester wants to merge 1 commit intotektoncd:release-v1.6.xfrom
Closed
fix(pipelinerun): add missing sort logic for childRefs array#9356vdemeester wants to merge 1 commit intotektoncd:release-v1.6.xfrom
vdemeester wants to merge 1 commit intotektoncd:release-v1.6.xfrom
Conversation
The previous cherry-pick (tektoncd#9314) only included the test file changes (removing cmpopts.SortSlices) but not the actual sorting logic in pipelinerun.go. This caused tests to fail because they expected sorted output but the production code wasn't sorting. This commit adds the missing sort.Slice call that sorts childRefs by PipelineTaskName, then Name, then Kind to prevent excessive status updates caused by unordered arrays. Cherry-pick of the missing part from tektoncd#9295. Signed-off-by: Vincent Demeester <[email protected]> Co-Authored-By: Claude <[email protected]>
tekton-robot
added
kind/bug
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a manual cherry-pick fix for #9295 to release-v1.6.x.
Problem
The previous cherry-pick (#9314) only included the test file changes (removing
cmpopts.SortSlices) but not the actual sorting logic inpipelinerun.go. This caused the tests to fail because they expected sorted output but the production code wasn't sorting.Solution
This commit adds the missing
sort.Slicecall that sortschildRefsby:PipelineTaskNameNameKindThis prevents excessive status updates caused by unordered arrays, which was the original goal of #9295.
Testing
TestUpdatePipelineRunStatusFromChildRefs- all tests pass/kind bug
Release Notes