Skip to content

[cherry-pick: release-v1.0.x] fix: Prevent excessive reconciliation when timeout disabled#9304

Closed
tekton-robot wants to merge 1 commit intorelease-v1.0.xfrom
cherry-pick-9202-to-release-v1.0.x
Closed

[cherry-pick: release-v1.0.x] fix: Prevent excessive reconciliation when timeout disabled#9304
tekton-robot wants to merge 1 commit intorelease-v1.0.xfrom
cherry-pick-9202-to-release-v1.0.x

Conversation

@tekton-robot
Copy link
Collaborator

This is a cherry-pick of #9202


Changes

  • Stop immediate requeue loops when default-timeout-minutes is "0"
  • Remove redundant hasCondition checks (Knative already deduplicates)

This adds an e2e tests that looks at pipeline logs to see how much reconciler loop there is. If you run it before the fix, it would count more than 1500 reconciler loop, whereas with the fix, only about 10.

/cc @afrittoli @pritidesai @tektoncd/core-maintainers

It took me a while to figure out, and I got some help from Claude (AI) to write the tests. The previous behavior seemed very weird as well, with no timeout, we would, re-queue instantly, which is.. madness 🙃

/kind bug

Fixes #8495

This could be a good candidate to be backported.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Fix an issue where there was excessive reconciliation in case of no timeout on TaskRun or PipelineRun.

@tekton-robot tekton-robot requested review from a team and pritidesai January 26, 2026 14:55
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jan 26, 2026
@tekton-robot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jerop after the PR has been reviewed.
You can assign the PR to them by writing /assign @jerop in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 26, 2026
@vdemeester
Copy link
Member

/hold

I wonder why the CI didn't start on this one..

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 26, 2026
@vdemeester
Copy link
Member

Needs #9305 to be merged first.

- Stop immediate requeue loops when default-timeout-minutes is "0"
- Remove redundant hasCondition checks (Knative already deduplicates)

This adds an e2e tests that looks at pipeline logs to see how much
reconciler loop there is. If you run it before the fix, it would count
more than 1500 reconciler loop, whereas with the fix, only about 10.

Signed-off-by: Vincent Demeester <[email protected]>
Co-Authored-By: Claude <[email protected]>
@vdemeester vdemeester force-pushed the cherry-pick-9202-to-release-v1.0.x branch from f023900 to 7088f41 Compare January 27, 2026 10:47
@vdemeester vdemeester closed this Jan 30, 2026
@vdemeester vdemeester deleted the cherry-pick-9202-to-release-v1.0.x branch January 30, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants