Skip to content

fix(pipelinerun): fix the issue of massive invalid status updates caused by unordered arrays, which will greatly impact the resource load and stability of the apiserver. #9295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tekton-robot merged 2 commits into from
Jan 21, 2026
+15 −3
Merged

fix(pipelinerun): fix the issue of massive invalid status updates caused by unordered arrays, which will greatly impact the resource load and stability of the apiserver. #9295

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e759e2
fix(pipelinerun): fix the issue of massive invalid status updates cau…
Pangjiping Jan 18, 2026
9b213bb
chore(pipelinerun): remove cmpopts.SortSlices from pkg/reconciler/pip…
Pangjiping Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions pkg/reconciler/pipelinerun/pipelinerun.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"path/filepath"
"reflect"
"regexp"
"sort"
"strings"

"k8s.io/apimachinery/pkg/util/wait"
Expand Down Expand Up @@ -1905,6 +1906,18 @@ func updatePipelineRunStatusFromChildRefs(logger *zap.SugaredLogger, pr *v1.Pipe
for k := range childRefByName {
newChildRefs = append(newChildRefs, *childRefByName[k])
}

// sorting childRef in a specific order can greatly avoid
// meaningless updates of status caused by unordered arrays.
sort.Slice(newChildRefs, func(i, j int) bool {
if newChildRefs[i].PipelineTaskName == newChildRefs[j].PipelineTaskName {
if newChildRefs[i].Name == newChildRefs[j].Name {
return newChildRefs[i].Kind < newChildRefs[j].Kind
}
return newChildRefs[i].Name < newChildRefs[j].Name
}
return newChildRefs[i].PipelineTaskName < newChildRefs[j].PipelineTaskName
})
pr.Status.ChildReferences = newChildRefs
}

Expand Down