fix(e2e): improve dind-sidecar probe configuration for reliability #9241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add startupProbe to accommodate slow Docker daemon initialization - Allow up to 30 seconds for daemon startup before marking as failed - Verify daemon functionality with 'docker info' instead of cert existence - Tries to address flaky test failures in CI with k8s native sidecar support Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot
added
the
do-not-merge/release-note-label-needed
tekton-robot
added
size/S
Member
Author
|
/kind flake |
tekton-robot
added
the
kind/flake
Contributor
|
/lgtm |
Collaborator
|
@anithapriyanatarajan: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Member
|
@vdemeester looks like a rebase is needed.. |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This was referenced Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Improves the
dind-sidecar.yamlexample test reliability by adding astartupProbeand enhancing thereadinessProbe:docker infoto verify the daemon is actually ready to accept commandsenableKubernetesSidecar: true, while readinessProbe may not beThis addresses flaky test failures seen in CI, particularly in alpha mode with k8s native sidecar support enabled.
Related analysis:
dind-sidecar-failure-analysis.md(Nov 28, 2025)Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes