Skip to content

Fix duplicated protobuf tag in pod.Template struct#9229

Merged
tekton-robot merged 1 commit intotektoncd:mainfrom
SarthakPandey2002:fix-protobuf-tag-8345
Dec 18, 2025
Merged

Fix duplicated protobuf tag in pod.Template struct#9229
tekton-robot merged 1 commit intotektoncd:mainfrom
SarthakPandey2002:fix-protobuf-tag-8345

Conversation

@SarthakPandey2002
Copy link

@SarthakPandey2002 SarthakPandey2002 commented Dec 13, 2025 •
edited by waveywaves
Loading

Summary

Fixes duplicate protobuf tag number in pkg/apis/pipeline/pod/template.go.

Changes

  • Changed PriorityClassName protobuf tag from 7 to 8
  • Tag 7 was already used by Env field
  • Tag 8 is the next available sequential number

Issue

Fixes #8345

Testing

Verified tag 8 is not used elsewhere in the Template struct.

Release Notes

fix duplicate protobuf tag for PriorityClassName in pod.Template struct

@SarthakAltudo
Fix duplicated protobuf tag in pod.Template struct
253713e 
  Change PriorityClassName protobuf tag from 7 to 8 to resolve
  duplicate tag number conflict with Env field.
  Fixes tektoncd#8345
@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 13, 2025
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 13, 2025 •
edited
Loading

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: SarthakAltudo / name: Sarthak Pandey (253713e)

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 13, 2025
@waveywaves
Copy link
Member

waveywaves commented Dec 16, 2025

@SarthakAltudo thank you for the contribution ! Do sign the CLA so we can move forward with the reviews

@github-project-automation github-project-automation bot moved this from Done to In Progress in Tekton Community Roadmap Dec 16, 2025
@SarthakPandey2002
Copy link
Author

SarthakPandey2002 commented Dec 16, 2025

@SarthakAltudo thank you for the contribution ! Do sign the CLA so we can move forward with the reviews

@waveywaves signed the CLA
@abayer @twoGiants Please review this PR

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2025
@waveywaves waveywaves added the kind/bug Categorizes issue or PR as related to a bug. label Dec 17, 2025
@waveywaves waveywaves self-assigned this Dec 17, 2025
waveywaves
waveywaves approved these changes Dec 17, 2025
View reviewed changes
Copy link
Member

@waveywaves waveywaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thank you for this fix !

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2025
@tekton-robot
Copy link
Collaborator

tekton-robot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 18, 2025
@tekton-robot tekton-robot merged commit 265b11e into tektoncd:main Dec 18, 2025
26 of 28 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Tekton Community Roadmap Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdemeester vdemeester vdemeester approved these changes

@waveywaves waveywaves waveywaves approved these changes

@abayer abayer Awaiting requested review from abayer

@twoGiants twoGiants Awaiting requested review from twoGiants

Assignees

@waveywaves waveywaves

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Tekton Community Roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicated protobuf tag number in pod.Template struct

5 participants

@SarthakPandey2002 @waveywaves @tekton-robot @vdemeester @SarthakAltudo