Skip to content

Fix commit SHA of github-script action#9203

Merged
vdemeester merged 1 commit intotektoncd:mainfrom
AlanGreene:e2e_extras
Dec 3, 2025
Merged

Fix commit SHA of github-script action#9203
vdemeester merged 1 commit intotektoncd:mainfrom
AlanGreene:e2e_extras

Conversation

@AlanGreene
Copy link
Member

Changes

Follow-up to #9161
2 uses of the github-script action were referencing an invalid SHA. Update to point to the correct value for the 7.0.1 release.

Not sure why I thought they had already been updated as mentioned in the original PR, I must have been working from a different branch.
/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

2 uses of the github-script action were referencing an invalid SHA.
Update to point to the correct value for the 7.0.1 release.
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Dec 3, 2025
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 3, 2025
@AlanGreene
Copy link
Member Author

/cc @vdemeester

@AlanGreene
Copy link
Member Author

/retest

@vdemeester
Copy link
Member

@AlanGreene won't this be fixed by #9195 ?

@AlanGreene
Copy link
Member Author

Ah I didn't see that PR. Yes it updates the SHA to v8, but because 2 of the existing SHAs are wrong it doesn't correctly update the version comment.

If we merge this PR the commits will match the version, then we can rebase the dependabot PR and it should update the comments correctly too.

@vdemeester
Copy link
Member

/approve
/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2025
@vdemeester vdemeester merged commit bc1e05b into tektoncd:main Dec 3, 2025
20 of 23 checks passed
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Dec 3, 2025
@AlanGreene AlanGreene deleted the e2e_extras branch December 3, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants