-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore(release-pipeline): update references to oci bucket #9189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release-pipeline): update references to oci bucket #9189
Conversation
|
Need this to be on hold until the PRs in plumbing repos related to this PR are merged. Will update the details here shortly |
Could you include a link to said PRs please? |
@afrittoli Please review - tektoncd/plumbing#2948 |
fdf522d to
2d5417a
Compare
|
The plumbing PR is now merged 👼🏼 |
Signed-off-by: Anitha Natarajan <[email protected]>
02126d7 to
9eb642f
Compare
|
@vdemeester @afrittoli - Thankyou. Updated release pipeline and cheatsheet with the prcheck task and upload tasks poiting the latest plumbing and catalog versions. Please review |
|
/retest |
afrittoli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| ``` | ||
| Sample secret template for reference: | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: missing new-lines
| kubectl apply -f tekton/account.yaml | ||
| kubectl patch serviceaccount $ACCOUNT \ | ||
| -p "{\"secrets\": [{\"name\": \"$GENERIC_SECRET\"}]}" | ||
| 1. When executing release pipelines, some tasks require `oci cli` commands. The CLI requires credentials which should be created as a Kubernetes secret and mounted to the respective task's workspace. For example refer the precheck definition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: It's ok to explain this, as it may be handy for troubleshooting.
The cheat-sheet should be an operational guide to what needs to be done step by step to make a release. The secret is deployed to the cluster via terraform, so the release manager should not need to create the secret.
| TEKTON_OLD_VERSION= # Example: v0.68.0 | ||
| TEKTON_RELEASE_NAME="Oriental Longhair Omnibot" # Name of the release | ||
| TEKTON_PACKAGE=tektoncd/pipeline | ||
| TEKTON_REPO_NAME=pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Why do we need this here? The repo name is already set to the valid default in the pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a needed for release-draft-oci pipeline that is called from plumbing repo.
|
/lgtm |
| --param releaseBucket=gs://tekton-releases/pipeline \ | ||
| --param releaseBucket=tekton-releases \ | ||
| --param koExtraArgs="" \ | ||
| --workspace name=release-secret,secret=release-secret \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be oci-release-secret
| ```bash | ||
| RELEASE_FILE=https://storage.googleapis.com/tekton-releases/pipeline/previous/${TEKTON_VERSION}/release.yaml | ||
| CONTROLLER_IMAGE_SHA=$(curl $RELEASE_FILE | egrep 'ghcr.io.*controller' | cut -d'@' -f2) | ||
| RELEASE_FILE=https://infra.tekton.dev/tekton-releases/triggers/previous/${VERSION_TAG}/release.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VERSION_TAG is not defined, it should be TEKTON_VERSION as it was before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project is not triggers, it should be pipeline as it was
| Create a pod template file: | ||
|
|
||
| ```shell | ||
| cat <<EOF > tekton/pod-template.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This writes the file to tekton/pod-template.yaml and right after tries to get the file as pod-template.yaml (without the folder). Could you change this to pod-template instead?
We could add this file and the workspace one to .gitignore or we could do something like:
POD_TEMPLATE=$(mktemp)
cat <<EOF > $POD_TEMPLATE
(...)
--pod-template "${POD_TEMPLATE}" \for both files
| Optional: Add a photo of this release's "purr programmer" (someone's cat). | ||
|
|
||
| 1. Update [the catalog repo](https://github.com/tektoncd/catalog) test infrastructure | ||
| to use the new release by updating the `RELEASE_YAML` link in [e2e-tests.sh](https://github.com/tektoncd/catalog/blob/main/test/e2e-tests.sh). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to update this in the past, perhaps you could update it as well?
1. Update [the catalog repo](https://github.com/tektoncd/catalog) test infrastructure
to use the new release by updating the test matrix in the `[ci.yaml](https://github.com/tektoncd/catalog/blob/main/.github/workflows/ci.yaml)`.
Changes
This pull request updates the Tekton release cheat sheet and release pipeline to reflect new infrastructure and workflow changes, primarily switching from Google Cloud (GCP) to Oracle Cloud Infrastructure (OCI) and updating release URLs. The changes standardize release parameters, update secret and bucket references, and revise instructions for interacting with clusters and release files.
Infrastructure and URL updates:
storage.googleapis.comtoinfra.tekton.dev, ensuring consistency with the new hosting location.gcloud(GCP) to OCI CLI commands, reflecting the migration to Oracle Cloud.Parameter and secret updates:
serviceaccount,serviceAccountPath), addingrepoName, and updating secret references fromrelease-secrettooci-release-secretwhere appropriate.Release workflow improvements:
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind misc