fix: Populate step statuses before TaskRun timeout handling#9184
Merged
tekton-robot merged 1 commit intotektoncd:mainfrom Nov 28, 2025
Merged
fix: Populate step statuses before TaskRun timeout handling#9184tekton-robot merged 1 commit intotektoncd:mainfrom
tekton-robot merged 1 commit intotektoncd:mainfrom
Conversation
tekton-robot
added
the
release-note
tekton-robot
added
the
size/M
Member
Author
|
/kind bug |
vdemeester
added
kind/flake
Member
Author
|
cc @tektoncd/core-maintainers |
Member
Author
|
I wonder if there is other issues related to this in the issue tracker 🤔 |
vdemeester
removed
the
kind/flake
vdemeester
force-pushed
the
731-taskruntimeout-flake
branch
from
3e92ec5 to
1d9debf
Compare
afrittoli
reviewed
Nov 27, 2025
This prevent some race condition where timeout fires before pod status fetch. TestTaskRunTimeout validates that steps are terminated, but it can be not populated from time to time (in my test 4/5 times out of 25). Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
731-taskruntimeout-flake
branch
from
1d9debf to
9732652
Compare
tekton-robot
added
size/L
tekton-robot
added
the
approved
Member
|
Examples are failing. /retest |
twoGiants
approved these changes
Nov 28, 2025
Member
twoGiants
left a comment
twoGiants
left a comment
There was a problem hiding this comment.
Nice! Good fix 😸
/approve
/lgtm
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, twoGiants The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This prevent some race condition where timeout fires before pod status
fetch. TestTaskRunTimeout validates that steps are terminated, but it
can be not populated from time to time (in my test 4/5 times out of 25).
Fixes #731
This should reduce a lot flakes on timeout tests.
I am not sure if we need a release note or not. It does fix a bug though.
Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes