-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: upload release manifests to oracle cloud #9121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upload release manifests to oracle cloud #9121
Conversation
|
@anithapriyanatarajan: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/kind misc |
|
@anithapriyanatarajan: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/kind misc |
|
@afrittoli @vdemeester - The following assumptions were made for this PR.
|
|
/retest |
8ecc2a7 to
c89de24
Compare
| description: 'Oracle Cloud bucket name for builds' | ||
| required: false | ||
| default: 'gs://tekton-releases-nightly/pipeline' | ||
| default: 'tekton-releases-nightly' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be tekton-nightly for the new OCI bucket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thankyou. Resubmitted with updated bucket name. But the GHCR imageRegistryPath -https://github.com/anithapriyanatarajan/pipeline/blob/865d2ff9b6646475a5efd759fdac888d9072ce90/tekton/release-pipeline.yaml#L21 is still the same. Hope this is fine.
0975d60 to
865d2ff
Compare
tekton/release-pipeline.yaml
Outdated
| # Format: https://infra.tekton.dev/tekton-nightly/<repoName>/previous/<versionTag> | ||
| BASE_URL="https://infra.tekton.dev/tekton-nightly/${REPO_NAME}/previous/${VERSION_TAG}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should use releaseBucket to construct the correct URL since this pipeline is also used for official releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was overlooked. Thankyou for pointing out
| description: 'Nightly bucket for builds' | ||
| description: 'Oracle Cloud bucket name for builds' | ||
| required: false | ||
| default: 'gs://tekton-releases-nightly/pipeline' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason for removing the repo name from the bucket config and making it a separate param?
This pipeline should always publish to <bucket>/pipeline so making it configurable seems unusual, unless we're planning to use this as a template for a generic pipeline that can be reused across multiple repos. In which case, I think there are likely many other changes that would be required so each repo can customise the pipeline to their needs, and would require careful design before implementing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Oracle cloud, I was not able to pass the bucket name as /pipeline. Hence introduced a new param called reponame and pass as object prefix. https://github.com/anithapriyanatarajan/pipeline/blob/865d2ff9b6646475a5efd759fdac888d9072ce90/.github/workflows/nightly-builds.yaml#L24
Yes, the bucket name is
Yes, it's the same. This is one example item:
+1
+1 |
dd67593 to
933ab09
Compare
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
afrittoli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
AlanGreene
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anithapriyanatarajan
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, AlanGreene The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Changes
This PR incorporates the listed changes to ensure Tekton's nightly release artifacts are stored and published using Oracle Cloud for future releases.
gs://...) to Oracle Cloud (tekton-nightly), updating default bucket names and related descriptions in both.github/workflows/nightly-builds.yamlandtekton/release-pipeline.yaml.OCI_API_KEY,OCI_FINGERPRINT, etc.) from workflow secrets instead of GCS service account keys, and changed secret creation logic accordingly.repoNameparameter to both the workflow and pipeline for improved artifact organization, and passedSubmitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind feat