[release-v1.0.x] fix: exclude pending PipelineRuns from tekton_pipelines_controller_running_pipelineruns metric#8979
Conversation
…nning_pipelineruns metric The running_pipelineruns metric incorrectly counted pending PipelineRuns as running. Add !pr.IsPending() check to exclude them. Fixes tektoncd#8949 Signed-off-by: divyansh42 <diagrawa@redhat.com>
|
@tekton-robot: GitHub didn't allow me to assign the following users: divyansh42. Note that only tektoncd members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
release-note
tekton-robot
added
the
size/S
|
The following is the coverage report on the affected files.
|
|
/retest |
1 similar comment
|
/retest |
|
/approve |
waveywaves
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3 participants
This is an automated cherry-pick of #8951
/assign divyansh42