exponential backoff in taskRun controller#8926
Merged
tekton-robot merged 1 commit intotektoncd:mainfrom Jul 30, 2025
Merged
Conversation
Add exponential backoff retry logic to the TaskRun controller for pod creation, providing better resilience against transient webhook timeout errors while maintaining immediate failure for permanent errors. Signed-off-by: Priti Desai <[email protected]>
tekton-robot
added
release-note
tekton-robot
added
the
size/L
Collaborator
|
The following is the coverage report on the affected files.
|
Member
Author
|
@afrittoli @vdemeester please take a look, thanks! |
afrittoli
reviewed
Jul 29, 2025
Member
afrittoli
left a comment
afrittoli
left a comment
There was a problem hiding this comment.
Thank you @pritidesai!
/approve
tekton-robot
added
the
approved
waveywaves
reviewed
Jul 29, 2025
|
|
||
| // IsWebhookTimeout checks if the error is due to a mutating admission webhook timeout. | ||
| // This function is used to determine if an error should trigger exponential backoff retry logic. | ||
| func IsWebhookTimeout(err error) bool { |
waveywaves
reviewed
Jul 29, 2025
| expectCalls int | ||
| } | ||
|
|
||
| testCases := []testCase{ |
waveywaves
approved these changes
Jul 29, 2025
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, vdemeester, waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add exponential backoff retry logic to the TaskRun controller for pod creation, providing better resilience against transient webhook timeout errors while maintaining immediate failure for permanent errors.
Reference: #8902 (comment)
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes