Skip to content

[release-v0.65.x] adding efficient polling to waitForStepsToFinish#8911

Open
pritidesai wants to merge 3 commits intotektoncd:release-v0.65.xfrom
pritidesai:cherrypick-8901
Open

[release-v0.65.x] adding efficient polling to waitForStepsToFinish#8911
pritidesai wants to merge 3 commits intotektoncd:release-v0.65.xfrom
pritidesai:cherrypick-8901

Conversation

@pritidesai
Copy link
Member

@pritidesai pritidesai commented Jul 24, 2025

Changes

Manual Cherry-pick of #8901

#8901 (comment)

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

The log results sidecar has been optimized to significantly reduce CPU utilization.  Operators can tune the system for their environment—using a higher interval to reduce CPU load in production, or a lower interval for faster feedback in development or testing.

@pritidesai
adding efficient polling to waitForStepsToFinish
cae2c27 
The current waitForStepsToFinish implementation is a classic busy-wait.
It checks for file existence without any sleep, resulting in a high
CPU usage. Adding a profile with a unit test to show that almost all
time is spent in system calls with a high total sample count. This led to
execssive CPU usage by the sidecar even when just waiting.

The function now sleeps 100ms between checks, drastically reducing the
frequency. The sidecar now uses minimal CPU while waiting.

Signed-off-by: Priti Desai <pdesai@us.ibm.com>
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Jul 24, 2025
@tekton-robot
Copy link
Collaborator

tekton-robot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from pritidesai after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot requested review from afrittoli and dibyom July 24, 2025 21:41
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 24, 2025
@tekton-robot
Copy link
Collaborator

tekton-robot commented Jul 24, 2025

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
internal/sidecarlogresults/sidecarlogresults.go 87.6% 87.5% -0.1
pkg/pod/pod.go 93.4% 92.9% -0.4

@pritidesai
refactor getSidecarLogPollingInterval()
f90fbb5 
Introducing getSidecarLogPollingInterval() to avoid repeating the same
logic across two different functions.

Signed-off-by: Priti Desai <pdesai@us.ibm.com>
@tekton-robot
Copy link
Collaborator

tekton-robot commented Jul 24, 2025

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/pod.go 93.4% 92.9% -0.4

@vdemeester @pritidesai
Remove all reference to gcr.io tekton projects
0665f10 
There was still a few references that makes the CI fail. This should
fix it.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 1, 2025
@tekton-robot
Copy link
Collaborator

tekton-robot commented Aug 1, 2025

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/pod/pod.go 93.4% 92.9% -0.4

@waveywaves
Copy link
Member

waveywaves commented Aug 19, 2025

/retest

2 similar comments
@l-qing
Copy link
Member

l-qing commented Sep 5, 2025

/retest

@waveywaves
Copy link
Member

waveywaves commented Sep 10, 2025

/retest

@l-qing
Copy link
Member

l-qing commented Sep 14, 2025

We might need to cherry-pick this commit for the pipeline to succeed. 5f38010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afrittoli afrittoli Awaiting requested review from afrittoli

@dibyom dibyom Awaiting requested review from dibyom

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

Tekton Community Roadmap
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pritidesai @tekton-robot @waveywaves @l-qing @vdemeester