Generalize messages when TaskRun errs during pod creation#891
Merged
tekton-robot merged 1 commit intomasterfrom May 24, 2019
unknown repository
Merged
Generalize messages when TaskRun errs during pod creation#891tekton-robot merged 1 commit intomasterfrom unknown repository
tekton-robot merged 1 commit intomasterfrom
unknown repository
Conversation
Prior to this commit the messages recorded when a TaskRun's pod failed to create were specific to missing TaskSpec / TaskRef. This commit updates the messages to generalize a bit further - while it might be that a Task is missing the errors can also manifest when TaskRuns are invalid for other reasons (e.g. templating issues)
googlebot
added
the
cla: yes
tekton-robot
added
the
size/XS
Author
|
/retest |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom, sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #876 (comment), fyi @bobcatfish
Changes
Prior to this commit the messages recorded when a TaskRun's pod failed
to create were specific to a missing TaskSpec / TaskRef.
This commit updates the messages to generalize a bit further - while it
might be that a Task is missing errors can also manifest when
TaskRuns are invalid for other reasons (e.g. templating issues).
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Includes tests (if functionality changed/added)Includes docs (if user facing)Release Notes