nightly builds with gh actions#8897
Conversation
|
/kind misc |
|
@vdemeester @afrittoli - This PR is in response to tektoncd/plumbing#2670. Please review and share your comments. If the approach followed here for pipeline component is approved I could attempt the same approach across other components. The triggers related to pipeline could be removed from plumbing repo if this is approved. |
ba3a268 to
aa578a9
Compare
vdemeester
left a comment
There was a problem hiding this comment.
Some comments. It is "verbose" 😛
|
|
||
| echo "🔍 Analyzing repository configuration..." | ||
|
|
||
| if [[ "${{ github.repository }}" == "tektoncd/pipeline" ]]; then |
There was a problem hiding this comment.
NIT: If we move pipeline to a variable and use it throughout, it will be easier to adopt this into other repos. Perhaps we could even define this in tektoncd/actions or tektoncd/plumbing and reuse it across repos. This can be done as a follow-up.
There was a problem hiding this comment.
Yes some of this could be defined or used in tektoncd/actions
There was a problem hiding this comment.
@afrittoli @vdemeester - I would like to create a follow up PR to address this. Would like to understand each repo release yaml in depth before abstracting. Hope this is acceptable.
There was a problem hiding this comment.
Sure, it can be a follow-up. Even within this single repo PR the string "pipeline" is repeated many times in the workflow which is also why it would be nicer to have it in a variable.
2d2af30 to
a1a7f1d
Compare
Reduced verbosity to some extent now. Hope this helps a little 😸 |
|
/retest |
|
/test |
|
@anithapriyanatarajan: No presubmit jobs available for tektoncd/pipeline@main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
81dfffb to
a26057a
Compare
|
/retest |
afrittoli
left a comment
There was a problem hiding this comment.
Thank you for this; it's much appreciated!
I'm looking forward to using this as soon as it's ready.
One comment that I have is that I would really prefer to avoid duplicating all Tekton resources used for nightly builds and Tekton releases, because it generates double the maintenance effort. If anything, we should further factor things up across projects, where possible.
I don't see anything in the new pipeline that requires having a dedicated pipeline.
The org and repo parameters can be added in the release pipeline with valid defaults, so they do not impact the release process.
The cleanup task is not something I would have added as part of this PR. We could use existing actions like https://github.com/marketplace/actions/container-retention-policy for that.
In future, we may decide to move the entire build and release process to GHA action entirely, if we can solve the issue of signing ko built images in GHA.
Something that would be nice to see as a follow-up (separate PR) would be to start publishing the manifests of nightly builds somewhere on GitHub, so to drop the dependency from GCP there are well.
a26057a to
61a7228
Compare
fb5c012 to
73c8f43
Compare
9e3ceb6 to
71b13b8
Compare
afrittoli
left a comment
There was a problem hiding this comment.
Thanks for all the updates!
I have a couple more minor questions.
1782d43 to
7e49635
Compare
|
@afrittoli @vdemeester -I believe this PR is now in a good state. Most of the review comments have been addressed. I've aligned the use of the service account and image registry user with the guidance in the official documentation: The remaining open questions are:
|
9f30570 to
f43dc3c
Compare
afrittoli
left a comment
There was a problem hiding this comment.
Thanks for all the updates.
One very last change please, if we could continue to pin the precheck revision 🙏
f43dc3c to
894925c
Compare
f40634c to
2a83e31
Compare
afrittoli
left a comment
There was a problem hiding this comment.
Thanks for making this happen!!
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
This PR introduces a new GitHub Actions workflow that automates nightly releases of Tekton Pipeline using a Kind cluster as infrastructure. The existing pipeline-based approach to build and publish release artifacts is reused to ensure consistency with the current release process while enabling automated daily builds.
Core Implementation
Configuration
Required Secrets:
GHCR_TOKEN: GitHub Personal Access Token with
packages:writescopeGCS_SERVICE_ACCOUNT_KEY: Google Cloud Service Account for bucket access
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes