Feature: Allow THREADS_PER_CONTROLLER env var to override default threads-per-controller value

[valAndre07]

Changes

Linked issue : #8886

In order to use helm charts from cdfoundation to deploy tekton controller, it could be easier to add the possibility to configure threads-per-controller, kube-api-qps and kube-api-burst by environment variables rather than by args.

KUBE_API_BURST and KUBE_API_QPS env vars can already override kube-api-qps and kube-api-burst default value :

• KUBE_API_BURST
• KUBE_API_QPS

We just need to allow THREADS_PER_CONTROLLER env var to override default threads-per-controller value.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Default `threads-per-controller` value can be override by `THREADS_PER_CONTROLLER` env var

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: valAndre07 / name: ANDRE Valentin (a11bbe0)

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/resolvers/main.go	29.4%	22.7%	-6.7

[valAndre07]

/kind feature

[afrittoli]

Thanks for this!
It looks good, just a small question.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/resolvers/main.go	29.4%	22.7%	-6.7

[valAndre07]

/test pull-tekton-pipeline-go-coverage-df

[tekton-robot]

@valAndre07: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/resolvers/main.go	29.4%	22.7%	-6.7

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/resolvers/main.go	29.4%	22.7%	-6.7

[tekton-robot]

@valAndre07: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test ci / e2e-tests / e2e tests (k8s-plus-one, alpha) (pull_request)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[valAndre07]

/ok-to-test

[tekton-robot]

@valAndre07: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[afrittoli]

/retest

[afrittoli]

Thank you!
/approve

[valAndre07]

Thanks a lot for the approve @afrittoli 😃
Can you explain me what is the next step ?

[afrittoli]

Thanks a lot for the approve @afrittoli 😃 Can you explain me what is the next step ?

Of course. We have a policy of two reviews for pipeline PRs, once another maintainer approves, they'll add an lgtm comment and the PR will be automatically be merged.

If the second reviewer requests changes, and new update on the PR will be required instead.

[afrittoli]

/cc @vdemeester

[afrittoli]

/cc @twoGiants

[twoGiants]

Looks good 👍

[twoGiants]

/approve
/lgtm
/meow

[tekton-robot]

@twoGiants:

Details

In response to this:

/approve
/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [afrittoli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment