[TEP-0056]: Extract common status helper functions from pipelinerun_test.go.

[twoGiants]

Changes

Create pkg/reconciler/testing/status.go and move status related helper functions for TaskRun/CustomRun and later PipelineRun there. Remove duplication from helper functions.

Move yaml parsing helper functions to test/parse/yaml.go.

Rename import ttesting ==> th, short for "testing helpers".

Issue #8760, #7166.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/testing/status.go	Do not exist	0.0%

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/testing/status.go	Do not exist	0.0%

[vdemeester]

cc @afrittoli @waveywaves

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[afrittoli]

Thanks @twoGiants - is the idea that these functions will be used elsewhere in testing as well, e.g. for pip testing?
/lgtm

[twoGiants]

Thanks @twoGiants - is the idea that these functions will be used elsewhere in testing as well, e.g. for pip testing?

@afrittoli they are already, see here. I extracted them into the new file and extend them with pip related helpers here in my working branch. I want to avoid bloating pipelinerun_test.go anymore which has 19k lines of code and contains different types of tests and helpers.

I started to put the pip tests which are not part of a table driven test cases in existing test functions in their own file here. This file will grow when more functionality (Params, Timeouts, Results, ...) will be implemented.

I think that is how pipelinerun_test.go could actually be refactored:

• pipelinerun_pinp_test.go
• pipelinerun_task_test.go
• pipelinerun_customtask_test.go
• maybe pipelinerun_test.go with stuff which does not belong to any of the three or applies to all of them, not sure yet
• and the shared test framework in pkg/reconciler/testing
  • configmap.go
  • factory.go => mock data creation
  • status.go
  • fakecontroller.go => test env setup and reconcileOnce / reconcileWithError functions
  • validators.go
  • selectors.go => getTaskRunByName, getTaskRunsForPipelineRun, ...
  • ... probably more

Even without refactoring the actual helpers/tests much, this will reduce the cognitive load in the tests by an order of magnitude. Working in this giant pipelinerun_test.go test file turned out as the most difficult part so far.