Migration to golangci-lint v2…

[vdemeester]

Changes

Also updating the action as it is tied to it.

Signed-off-by: Vincent Demeester vincent@sbr.pm

Closes #8740

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[vdemeester]

cc @waveywaves

[vdemeester]

/cc @waveywaves

[waveywaves]

✨

[waveywaves]

should we still keep these rules, they are good for documentation

- EXC0012  # Checks if exported elements have comments
- EXC0014  # Checks if comments on exported elements have proper form

[vdemeester]

Ah I ran golangci-lint migrate and it removed it, I wonder if it's still something configurable or not.

[waveywaves]

I think we can add it later, it's not a blocker

[waveywaves]

TODO ^

[afrittoli]

I think golangci-lint v2 no longer has "off-by-default" functionality.
Apart from path specific exclusions, the new configuation is

  exclusions:
    generated: lax
    presets:
      - common-false-positives
      - legacy
      - std-error-handling

Which I think means that those comment rules are on.
It should be possible to verify by breaking a comment and running lint

[waveywaves]

Thank you for checking this Andrea

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [waveywaves]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vdemeester]

@afrittoli @abayer 🙏🏼

[abayer]

/lgtm

[waveywaves]

/cherry-pick release-v1.0.x

[tekton-robot]

@waveywaves: new pull request created: #8942

Details

In response to this:

/cherry-pick release-v1.0.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.