Raise test coverage in task_validation.go and container_validation.go.

[twoGiants]

Changes

Add test for checking duplicate names of steps and a success test when the enable-artifacts feature flag is not enabled. This raises the test coverage of container_validation.go to 100%. Replace ErrInvalidValue with ErrMultipleOneOf like in the pipeline validation tests for duplicate tasks.

Add a test for checking of object params without properties and using an object param in step environment variable value where it is forbidden which raises the coverage of task_validation.go to 99.1%.

Issue #8700.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	98.6%	99.1%	0.5

[waveywaves]

/kind test

[tekton-robot]

@waveywaves: The label(s) kind/test cannot be applied, because the repository doesn't have them.

Details

In response to this:

/kind test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[twoGiants]

/test check-pr-has-kind-label

[tekton-robot]

@twoGiants: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[waveywaves]

/ok-to-test

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/container_validation.go	98.8%	99.4%	0.6
pkg/apis/pipeline/v1/task_validation.go	98.2%	99.1%	0.9

[twoGiants]

/cc @waveywaves

This one is ready for review. It's small and improves test coverage. Thank you for the review! 😸

[twoGiants]

/ok-to-test

Added one more test now that the logic changed. We're back to 100% coverage for container_validation.go.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/container_validation.go	98.8%	100.0%	1.2
pkg/apis/pipeline/v1/task_validation.go	98.2%	99.1%	0.9

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester, waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [vdemeester,waveywaves]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[waveywaves]

/lgtm