Refactor sidecar validation to implement apis.Validatable.#8710
Merged
tekton-robot merged 1 commit intotektoncd:mainfrom May 12, 2025
Conversation
tekton-robot
added
kind/cleanup
twoGiants
force-pushed
the
issue-8700-refactor-sidecar-validation-to-implement-validatable
branch
from
9b1e82f to
f53931c
Compare
twoGiants
changed the title
25 tasks
Collaborator
|
The following is the coverage report on the affected files.
|
twoGiants
force-pushed
the
issue-8700-refactor-sidecar-validation-to-implement-validatable
branch
from
f53931c to
c94395e
Compare
Collaborator
|
The following is the coverage report on the affected files.
|
Collaborator
|
The following is the coverage report on the affected files.
|
Member
Author
|
@binkkatal you can take a look but I would wait till #8685 is merged, then this PR will be much smaller. See pr message above. Thank you! |
tekton-robot
added
the
needs-rebase
twoGiants
force-pushed
the
issue-8700-refactor-sidecar-validation-to-implement-validatable
branch
from
c94395e to
77a7a7a
Compare
tekton-robot
added
size/L
Add `SidecarList` with a `Validate` method and implemented a `Validate` method on `Sidecar`. Put both Sidecar tests into one test function and move into `container_validation_test.go`. Remove `validateSidecars`, `validateSidecar`, switch to `Validate` method entirely and remove old tests. Issue tektoncd#8700. Signed-off-by: Stanislav Jakuschevskij <[email protected]>
twoGiants
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
twoGiants
force-pushed
the
issue-8700-refactor-sidecar-validation-to-implement-validatable
branch
from
77a7a7a to
2e56a9d
Compare
Member
Author
|
/cc @waveywaves This one is ready for review. It's a small refactor of the sidecar validation, see my short description above. Thank you for the review! 😸 |
vdemeester
approved these changes
May 12, 2025
tekton-robot
added
the
approved
waveywaves
approved these changes
May 12, 2025
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester, waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
This was referenced May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
As a follow up to #8685 in this small PR the
Sidecarvalidation is refactored to align with the pattern used inpipeline_validation.go, task_validation.go, result_validation.go, etc.meaning implementing theapis.Validatableinterface and using a custom type for a list ofSidecarsnamelySidecarList.Now that the
Sidecarvalidation has a publicValidateAPI, the tests for it were moved fromtask_validation_test.gotocontainer_validation_test.gowhich also improves coverage.Issue #8700.
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes