feat: override task timeouts in pipelineruns by waveywaves · Pull Request #8636 · tektoncd/pipeline

waveywaves · 2025-03-11T14:47:47Z

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
pre-commit Passed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

feature: PipelineRun can now override individual task timeouts with spec.taskRunSpecs[].timeout

waveywaves · 2025-03-11T14:48:26Z

/kind feature

tekton-robot · 2025-03-11T14:59:03Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipelinerun_types.go	92.5%	92.5%	0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go	94.7%	93.8%	-0.9

tekton-robot · 2025-03-11T15:24:21Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipelinerun_types.go	92.5%	92.5%	0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go	94.7%	93.8%	-0.9

tekton-robot · 2025-03-28T23:58:06Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipelinerun_types.go	92.5%	92.5%	0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go	94.7%	93.8%	-0.9

tekton-robot · 2025-08-14T10:42:12Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipelinerun_types.go	92.5%	92.5%	0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go	94.7%	95.1%	0.4
pkg/apis/pipeline/v1/taskrun_validation.go	97.4%	97.4%	-0.0
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.7%	95.8%	0.0
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	89.7%	89.8%	0.1
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	97.2%	96.6%	-0.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go	97.4%	98.1%	0.6
pkg/reconciler/pipelinerun/pipelinerun.go	91.9%	92.1%	0.2

tekton-robot · 2025-08-14T11:26:25Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipelinerun_types.go	92.5%	92.5%	0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go	94.7%	95.1%	0.4
pkg/apis/pipeline/v1/taskrun_validation.go	97.4%	97.4%	-0.0
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.7%	95.8%	0.0
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	89.7%	89.8%	0.1
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	97.2%	96.6%	-0.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go	97.4%	98.1%	0.6
pkg/reconciler/pipelinerun/pipelinerun.go	91.9%	92.1%	0.2

waveywaves · 2025-08-14T13:53:49Z

/retest

aThorp96

/lgtm

One documentation suggestion to clarify the timeout assignment vs timeout enforcement behavior between TaskRuns and PipelineRuns. Otherwise this looks great. Thanks!

aThorp96 · 2025-08-14T15:30:20Z

docs/pipelineruns.md

Agreed, thanks for creating the followup issue as well! What you've added to that section looks good for the scope of this PR 🙏🏼

docs/pipelineruns.md

tekton-robot · 2025-08-14T17:11:02Z

@aThorp96: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

One documentation suggestion to clarify the timeout assignment vs timeout enforcement behavior between TaskRuns and PipelineRuns. Otherwise this looks great. Thanks!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2025-08-14T17:39:39Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipelinerun_types.go	92.5%	92.5%	0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go	94.7%	95.1%	0.4
pkg/apis/pipeline/v1/taskrun_validation.go	97.4%	97.4%	-0.0
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.7%	95.8%	0.0
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	89.7%	89.8%	0.1
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	97.2%	96.6%	-0.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go	97.4%	98.1%	0.6
pkg/reconciler/pipelinerun/pipelinerun.go	91.9%	92.1%	0.2

twoGiants

Looks great! The tests are very good. Thank you for the documentation update, it clarifies a lot. 😸 👍

I have found temporal coupling in the code. See my big comment below.

But all in all its good to go, it just needs some minor changes for a quick solution so it can be merged.

You could add a refactoring issue to centralize timeout validation for the community to pick up but its not a must.

docs/pipelineruns.md

pkg/apis/pipeline/v1/pipelinerun_validation.go

twoGiants · 2025-08-15T11:19:41Z

pkg/apis/pipeline/v1/pipelinerun_validation.go

+				errs = errs.Also(apis.ErrInvalidValue(
+					fmt.Sprintf("%s should be <= %s %s", taskRunTimeout.Duration, timeoutSource, maxTimeout.Duration),
+					"timeout"))


Suggested change

errs = errs.Also(apis.ErrInvalidValue(

fmt.Sprintf("%s should be <= %s %s", taskRunTimeout.Duration, timeoutSource, maxTimeout.Duration),

"timeout"))

return apis.ErrInvalidValue(

fmt.Sprintf("%s should be <= %s %s", taskRunTimeout.Duration, timeoutSource, maxTimeout.Duration),

"timeout")

pkg/apis/pipeline/v1/pipelinerun_validation.go

tekton-robot · 2025-08-15T12:39:02Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.7%	95.8%	0.0
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	89.7%	89.8%	0.1
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	97.2%	96.6%	-0.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go	97.4%	98.1%	0.6
pkg/reconciler/pipelinerun/pipelinerun.go	91.9%	92.1%	0.2

Signed-off-by: Vibhav Bobade <[email protected]>

tekton-robot · 2025-08-15T12:48:49Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.7%	95.8%	0.0
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	89.7%	89.8%	0.1
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	97.2%	96.6%	-0.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go	97.4%	98.1%	0.6
pkg/reconciler/pipelinerun/pipelinerun.go	91.9%	92.1%	0.2

tekton-robot · 2025-08-15T12:52:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aThorp96, twoGiants, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2025-08-15T12:53:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipelinerun_types.go	92.5%	92.5%	0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go	94.7%	94.9%	0.2
pkg/apis/pipeline/v1/taskrun_validation.go	97.4%	97.4%	-0.0
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.7%	95.8%	0.0
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	89.7%	89.8%	0.1
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	97.2%	96.6%	-0.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go	97.4%	98.1%	0.6
pkg/reconciler/pipelinerun/pipelinerun.go	91.9%	92.1%	0.2

twoGiants · 2025-08-15T12:53:54Z

/lgtm

tekton-robot · 2025-08-15T13:02:24Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipelinerun_types.go	92.5%	92.5%	0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go	94.7%	93.9%	-0.8
pkg/apis/pipeline/v1/taskrun_validation.go	97.4%	97.4%	-0.0
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.7%	95.8%	0.0
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	89.7%	89.8%	0.1
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	97.2%	95.7%	-1.4
pkg/apis/pipeline/v1beta1/taskrun_validation.go	97.4%	98.1%	0.6
pkg/reconciler/pipelinerun/pipelinerun.go	91.9%	92.1%	0.2

tekton-robot · 2025-08-15T13:04:54Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/pipelinerun_types.go	92.5%	92.5%	0.1
pkg/apis/pipeline/v1/pipelinerun_validation.go	94.7%	93.8%	-0.8
pkg/apis/pipeline/v1/taskrun_validation.go	97.4%	97.4%	-0.0
pkg/apis/pipeline/v1beta1/pipelinerun_conversion.go	95.7%	95.8%	0.0
pkg/apis/pipeline/v1beta1/pipelinerun_types.go	89.7%	89.8%	0.1
pkg/apis/pipeline/v1beta1/pipelinerun_validation.go	97.2%	95.7%	-1.5
pkg/apis/pipeline/v1beta1/taskrun_validation.go	97.4%	98.1%	0.6
pkg/reconciler/pipelinerun/pipelinerun.go	91.9%	92.1%	0.2

waveywaves · 2025-08-15T13:21:35Z

/retest

waveywaves · 2025-08-15T13:54:43Z

/retest

waveywaves · 2025-08-15T14:28:34Z

/retest

waveywaves · 2025-08-15T14:28:52Z

cornflakes > testflakes

github-project-automation bot added this to Tekton Community Roadmap Mar 11, 2025

github-project-automation bot moved this to Todo in Tekton Community Roadmap Mar 11, 2025

tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2025

tekton-robot requested review from afrittoli and dibyom March 11, 2025 14:47

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 11, 2025

waveywaves force-pushed the override-task-timeout branch from 41cbb8b to 1cb87f9 Compare March 11, 2025 15:12

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2025

waveywaves force-pushed the override-task-timeout branch from 1cb87f9 to d5ca69c Compare March 28, 2025 23:47

waveywaves force-pushed the override-task-timeout branch from d5ca69c to 0418ce7 Compare March 29, 2025 00:20

waveywaves closed this Mar 29, 2025

waveywaves force-pushed the override-task-timeout branch from 0418ce7 to 5b082b1 Compare March 29, 2025 00:27

github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Mar 29, 2025

tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2025

waveywaves reopened this Mar 29, 2025

github-project-automation bot moved this from Done to In Progress in Tekton Community Roadmap Mar 29, 2025

tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2025

waveywaves marked this pull request as ready for review March 29, 2025 00:31

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2025

waveywaves force-pushed the override-task-timeout branch from f1a4a4a to b10c867 Compare August 14, 2025 11:15

aThorp96 approved these changes Aug 14, 2025

View reviewed changes

twoGiants requested changes Aug 15, 2025

View reviewed changes

waveywaves force-pushed the override-task-timeout branch 3 times, most recently from c45c5af to 8aab142 Compare August 15, 2025 12:33

waveywaves force-pushed the override-task-timeout branch from 8aab142 to 075e4b6 Compare August 15, 2025 12:43

feat: override task timeout in pipelineruns

8679149

Signed-off-by: Vibhav Bobade <[email protected]>

waveywaves force-pushed the override-task-timeout branch from 075e4b6 to 8679149 Compare August 15, 2025 12:47

twoGiants approved these changes Aug 15, 2025

View reviewed changes

tekton-robot assigned twoGiants Aug 15, 2025

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2025

tekton-robot merged commit 665a03b into tektoncd:main Aug 15, 2025
87 of 92 checks passed

github-project-automation bot moved this from In Progress to Done in Tekton Community Roadmap Aug 15, 2025

Conversation

waveywaves commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

waveywaves commented Mar 11, 2025

Uh oh!

tekton-robot commented Mar 11, 2025

Uh oh!

tekton-robot commented Mar 11, 2025

Uh oh!

tekton-robot commented Mar 28, 2025

Uh oh!

tekton-robot commented Aug 14, 2025

Uh oh!

tekton-robot commented Aug 14, 2025

Uh oh!

waveywaves commented Aug 14, 2025

Uh oh!

aThorp96 left a comment

Choose a reason for hiding this comment

Uh oh!

aThorp96 Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tekton-robot commented Aug 14, 2025

Uh oh!

tekton-robot commented Aug 14, 2025

Uh oh!

twoGiants left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

twoGiants Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

waveywaves Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tekton-robot commented Aug 15, 2025

Uh oh!

tekton-robot commented Aug 15, 2025

Uh oh!

tekton-robot commented Aug 15, 2025

Uh oh!

tekton-robot commented Aug 15, 2025

Uh oh!

twoGiants commented Aug 15, 2025

Uh oh!

tekton-robot commented Aug 15, 2025

Uh oh!

tekton-robot commented Aug 15, 2025

Uh oh!

waveywaves commented Aug 15, 2025

Uh oh!

waveywaves commented Aug 15, 2025

Uh oh!

waveywaves commented Aug 15, 2025

Uh oh!

waveywaves commented Aug 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

waveywaves commented Mar 11, 2025 •

edited

Loading