chore: allow users with "read" perm to trigger retest

[waveywaves]

Changes

chore: allow users with "read" perm to trigger retest.
Currently developers on the repo; apart from the ones with "write" permissions, cannot trigger retests. this change allows users with "read" permissions to trigger retests.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
• Has Tests included if any functionality added or changed
• pre-commit Passed
• Follows the commit message standard
• Meets the Tekton contributor standards (including functionality, content, code)
• Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign imjasonh after the PR has been reviewed.
You can assign the PR to them by writing /assign @imjasonh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[waveywaves]

/kind misc

[tekton-robot]

@waveywaves: The label(s) kind/chore cannot be applied, because the repository doesn't have them.

Details

In response to this:

/kind chore

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[waveywaves]

/kind misc

[vdemeester]

This would make any member of the org to be able to run /retest right ?
If that's the case, I "think" it make sense as it's close to the behavior that was on prow jobs.

[vdemeester]

So the list of permissions are read, triage, write, maintain and admin.

I am not sure read means all users who can read or the one that are part of the org.

Triage: Recommended for contributors who need to proactively manage issues, discussions, and pull requests without write access

I think the @tektoncd/core-collaborators are in that case ? It might be a safer bet to start with ?

[vdemeester]

@afrittoli

[afrittoli]

Yes, this was restricted intentionally because we don't want anyone to be able to run the tests, but it needs to be refined.

Everyone in the org sounds good - we could support things like the "ok-to-test" label too for people outisde the org - that would need some extra logic in https://github.com/tektoncd/pipeline/blob/main/.github/workflows/chatops_retest.yaml.

In terms of permission, it is possible to specify none, which I believe would mean everyone.
Because of this setting, I believe people in the org will still have none permission on a repo, unless they are part of the collaborators team.

Setting to read here should expand the "retest" ability to the collaborators and then we could have a follow up to extend to org memebers and/or PRs with "ok-to-test".

[waveywaves]

@afrittoli created an issue based on your comment #8621

[waveywaves]

/test pull-tekton-pipeline-go-coverage-df

[tekton-robot]

@waveywaves: No presubmit jobs available for tektoncd/pipeline@main

Details

In response to this:

/test pull-tekton-pipeline-go-coverage-df

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

The following Tekton test failed:

Test name	Commit	Details	Required	Rerun command
pull-tekton-pipeline-go-coverage-df	642d636	link	true	/test pull-tekton-pipeline-go-coverage-df

[waveywaves]

I will add the ok-to-test option to this PR itself @afrittoli
cc @vdemeester