Skip to content

[release-v0.53.x] Use a maintained action for "changed files"#7490

Merged
tekton-robot merged 1 commit intotektoncd:release-v0.53.xfrom
JeromeJu:release-v0.53.x
Dec 13, 2023
Merged

[release-v0.53.x] Use a maintained action for "changed files"#7490
tekton-robot merged 1 commit intotektoncd:release-v0.53.xfrom
JeromeJu:release-v0.53.x

Conversation

@JeromeJu
Copy link
Member

Changes

Cherry-pick for 0.53.x of 7407
And replace "dummy" with "sample" in go tests to make woke happy :)

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

And replace "dummy" with "sample" in go tests to make `woke` happy :)

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2023
@JeromeJu JeromeJu added kind/misc Categorizes issue or PR as a miscellaneuous one. and removed kind/bug Categorizes issue or PR as related to a bug. labels Dec 13, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/taskref.go 92.6% 91.8% -0.9
pkg/reconciler/taskrun/taskrun.go 85.2% 85.1% -0.1

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/taskref.go 92.6% 91.8% -0.9
pkg/reconciler/taskrun/taskrun.go 85.2% 85.1% -0.1

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2023
Copy link
Member

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2023
@tekton-robot tekton-robot merged commit dace6fe into tektoncd:release-v0.53.x Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants