TEP-0142: Introduce Params and Results into StepActions CRD by chitrangpatel · Pull Request #7317 · tektoncd/pipeline

chitrangpatel · 2023-10-31T16:36:09Z

This PR introduces params and results into the StepAction CRD. It allows the StepAction to declare the params it needs and the results it will produce.
The follow up PRs will contain the interaction of how a Task referencing the StepAction resolves them.

All the tests were borrowed from pkg/apis/pipeline/v1/... that overlapped with paramSpec and Results.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

[WIP] Introduces params and results into the StepAction CRD.

/kind feature

tekton-robot · 2023-10-31T16:42:48Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/param_types.go	Do not exist	98.5%
pkg/apis/pipeline/v1alpha1/result_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/result_validation.go	Do not exist	94.4%
pkg/apis/pipeline/v1alpha1/stepaction_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/stepaction_validation.go	92.3%	99.1%	6.8

tekton-robot · 2023-10-31T16:44:10Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/param_types.go	Do not exist	98.5%
pkg/apis/pipeline/v1alpha1/result_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/result_validation.go	Do not exist	94.4%
pkg/apis/pipeline/v1alpha1/stepaction_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/stepaction_validation.go	92.3%	99.1%	6.8

tekton-robot · 2023-10-31T17:53:17Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/param_types.go	Do not exist	98.5%
pkg/apis/pipeline/v1alpha1/result_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/result_validation.go	Do not exist	94.4%
pkg/apis/pipeline/v1alpha1/stepaction_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/stepaction_validation.go	92.3%	99.1%	6.8

tekton-robot · 2023-10-31T17:54:36Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/param_types.go	Do not exist	98.5%
pkg/apis/pipeline/v1alpha1/result_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/result_validation.go	Do not exist	94.4%
pkg/apis/pipeline/v1alpha1/stepaction_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/stepaction_validation.go	92.3%	99.1%	6.8

pkg/apis/pipeline/v1alpha1/param_types.go

tekton-robot · 2023-10-31T18:28:33Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/param_types.go	Do not exist	98.5%
pkg/apis/pipeline/v1alpha1/result_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/result_validation.go	Do not exist	94.4%
pkg/apis/pipeline/v1alpha1/stepaction_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/stepaction_validation.go	92.3%	99.1%	6.8

tekton-robot · 2023-10-31T18:28:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/param_types.go	Do not exist	98.5%
pkg/apis/pipeline/v1alpha1/result_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/result_validation.go	Do not exist	94.4%
pkg/apis/pipeline/v1alpha1/stepaction_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/stepaction_validation.go	92.3%	99.1%	6.8

tekton-robot · 2023-10-31T18:30:15Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/param_types.go	Do not exist	98.5%
pkg/apis/pipeline/v1alpha1/result_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/result_validation.go	Do not exist	94.4%
pkg/apis/pipeline/v1alpha1/stepaction_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/stepaction_validation.go	92.3%	99.1%	6.8

tekton-robot · 2023-11-01T14:43:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Yongxuanzhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pkg/apis/pipeline/v1alpha1/param_types.go

tekton-robot · 2023-11-02T16:41:57Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/result_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/result_validation.go	Do not exist	94.4%
pkg/apis/pipeline/v1alpha1/stepaction_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/stepaction_validation.go	92.3%	98.7%	6.4

tekton-robot · 2023-11-02T19:18:40Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/result_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/result_validation.go	Do not exist	94.4%
pkg/apis/pipeline/v1alpha1/stepaction_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/stepaction_validation.go	92.3%	98.7%	6.4

This PR introduces `params` and `results` into the `StepAction` CRD. It allows the `StepAction` to declare the params it needs and the results it will produce. The follow up PRs will contain the interaction of how a `Task` referencing the `StepAction` resolves them. All the tests were borrowed from `pkg/apis/pipeline/v1/...` that overlapped with `paramSpec` and `Results`.

tekton-robot · 2023-11-03T16:34:21Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/result_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/result_validation.go	Do not exist	94.4%
pkg/apis/pipeline/v1alpha1/stepaction_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/stepaction_validation.go	92.3%	98.7%	6.4

tekton-robot · 2023-11-03T16:35:46Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1alpha1/result_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/result_validation.go	Do not exist	94.4%
pkg/apis/pipeline/v1alpha1/stepaction_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1alpha1/stepaction_validation.go	92.3%	98.7%	6.4

jerop

/unhold
/lgtm

Following the previous [PR](tektoncd#7317), which introduced Params to the `StepAction` CRD, this PR integrates `param` usage between `Steps` and `StepActions`. This completes support for params in `StepActions`. This work is part of issue tektoncd#7259.

Following the previous [PR](tektoncd#7317), which introduced Params to the `StepAction` CRD, this PR integrates `param` usage between `Steps` and `StepActions`. This PR adds the necessary syntax to `Steps` to pass `params` to `StepActions`. This work is part of issue tektoncd#7259.

Following the previous [PR](tektoncd#7317), which introduced Params to the `StepAction` CRD, this PR integrates `param` usage between `Steps` and `StepActions`. This completes support for params in `StepActions`. This work is part of issue tektoncd#7259.

Following the previous [PR](tektoncd#7317), which introduced Params to the `StepAction` CRD, this PR integrates `param` usage between `Steps` and `StepActions`. This PR adds the necessary syntax to `Steps` to pass `params` to `StepActions`. This work is part of issue tektoncd#7259.

Following the previous [PR](#7317), which introduced Params to the `StepAction` CRD, this PR integrates `param` usage between `Steps` and `StepActions`. This PR adds the necessary syntax to `Steps` to pass `params` to `StepActions`. This work is part of issue #7259.

Following the previous [PR](tektoncd#7317), which introduced Params to the `StepAction` CRD, this PR integrates `param` usage between `Steps` and `StepActions`. This completes support for params in `StepActions`. This work is part of issue tektoncd#7259.

Following the previous [PR](#7317), which introduced Params to the `StepAction` CRD, this PR integrates `param` usage between `Steps` and `StepActions`. This completes support for params in `StepActions`. This work is part of issue #7259.

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 31, 2023

tekton-robot requested review from afrittoli and vdemeester October 31, 2023 16:36

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 31, 2023

chitrangpatel mentioned this pull request Oct 31, 2023

TEP-0142: Enable Step Reusability - Implementation #7259

Closed

20 tasks

chitrangpatel force-pushed the step-actions-results-crd branch from 313a75a to 700bc4e Compare October 31, 2023 17:46

Yongxuanzhang reviewed Oct 31, 2023

View reviewed changes

pkg/apis/pipeline/v1alpha1/param_types.go Outdated Show resolved Hide resolved

pkg/apis/pipeline/v1alpha1/param_types.go Outdated Show resolved Hide resolved

chitrangpatel force-pushed the step-actions-results-crd branch 2 times, most recently from 4757779 to 66c61e7 Compare October 31, 2023 18:22

chitrangpatel requested a review from Yongxuanzhang October 31, 2023 18:26

Yongxuanzhang approved these changes Nov 1, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023

jerop reviewed Nov 2, 2023

View reviewed changes

pkg/apis/pipeline/v1alpha1/param_types.go Outdated Show resolved Hide resolved

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 2, 2023

chitrangpatel force-pushed the step-actions-results-crd branch from 66c61e7 to 9797496 Compare November 2, 2023 16:13

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2023

chitrangpatel force-pushed the step-actions-results-crd branch 3 times, most recently from 30d58c8 to 44f3368 Compare November 2, 2023 16:33

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 2, 2023

chitrangpatel force-pushed the step-actions-results-crd branch from 9c91b64 to 47eb4ad Compare November 3, 2023 16:27

jerop reviewed Nov 3, 2023

View reviewed changes

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2023

tekton-robot assigned jerop Nov 3, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2023

tekton-robot merged commit 695311e into tektoncd:main Nov 3, 2023

chitrangpatel mentioned this pull request Nov 3, 2023

TEP-0142: Add support for params between Step and StepActions #7332

Merged

7 tasks

chitrangpatel mentioned this pull request Nov 6, 2023

TEP-0142: Add syntax for providing params to StepActions #7334

Merged

7 tasks

jerop added this to the Pipelines v0.54 milestone Nov 9, 2023

chitrangpatel mentioned this pull request Nov 17, 2023

TEP-0142: Introduce StepResults in Steps, StepActions #7382

Merged

7 tasks

Conversation

chitrangpatel commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

tekton-robot commented Oct 31, 2023

Uh oh!

tekton-robot commented Oct 31, 2023

Uh oh!

tekton-robot commented Oct 31, 2023

Uh oh!

tekton-robot commented Oct 31, 2023

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Oct 31, 2023

Uh oh!

tekton-robot commented Oct 31, 2023

Uh oh!

tekton-robot commented Oct 31, 2023

Uh oh!

tekton-robot commented Nov 1, 2023

Uh oh!

Uh oh!

tekton-robot commented Nov 2, 2023

Uh oh!

tekton-robot commented Nov 2, 2023

Uh oh!

tekton-robot commented Nov 3, 2023

Uh oh!

tekton-robot commented Nov 3, 2023

Uh oh!

jerop left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chitrangpatel commented Oct 31, 2023 •

edited

Loading