Add credentials to HTTP resolver by chmouel · Pull Request #7315 · tektoncd/pipeline

chmouel · 2023-10-31T09:12:27Z

Changes

This adds the ability to pass credentials to the HTTP resolver when fetching the URL.

This let the user for example fetch a task from another SCM private repositories on another SCM providers than the one configured with the git resolver.

Fixes #7296

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

The http resolver supports passing username and password for fetching URLs with basic credentials

/kind feature

tekton-robot · 2023-10-31T09:20:32Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/http/resolver.go	92.5%	92.4%	-0.2

tekton-robot · 2023-10-31T09:21:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/http/resolver.go	92.5%	92.4%	-0.2

tekton-robot · 2023-10-31T11:27:39Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/http/resolver.go	92.5%	92.4%	-0.2

tekton-robot · 2023-10-31T11:28:54Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/http/resolver.go	92.5%	92.4%	-0.2

tekton-robot · 2023-10-31T14:36:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2023-11-06T08:15:46Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/http/resolver.go	92.5%	92.4%	-0.2

tekton-robot · 2023-11-06T08:17:44Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/http/resolver.go	92.5%	92.4%	-0.2

tekton-robot · 2023-11-07T08:00:00Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/http/resolver.go	92.5%	92.4%	-0.2

tekton-robot · 2023-11-07T08:22:37Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/http/resolver.go	92.5%	92.4%	-0.2

examples/v1/pipelineruns/beta/http-resolver-credentials.yaml

pkg/resolution/resolver/http/params.go

pkg/resolution/resolver/http/resolver.go

Yongxuanzhang · 2023-11-07T16:20:00Z

pkg/resolution/resolver/http/resolver.go

+			tokenSecretKey = v
+		}
+	}
+	secretNS := common.RequestNamespace(ctx)


The namespace is the same as the one with TaskRun/PiplineRun or from the default? I think we need to clarify which namespace we're using in the docs&docstrings

This adds the ability to pass credentials to the HTTP resolver when fetching the URL. This let's for example to fetch tasks from SCM private repositories on other SCM providers than configured with the git resolver. Fixes tektoncd#7296 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>

tekton-robot · 2023-11-15T12:21:14Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/http/resolver.go	92.5%	92.4%	-0.2

tekton-robot · 2023-11-15T12:21:23Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/resolution/resolver/http/resolver.go	92.5%	92.4%	-0.2

Yongxuanzhang · 2023-11-15T21:01:13Z

Thanks!
/lgtm

tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2023

tekton-robot requested review from abayer and jerop October 31, 2023 09:12

chmouel force-pushed the issue-7296-usernamepassword-support-in-http-resolver branch from e9fe4a9 to c9f92ad Compare October 31, 2023 11:21

vdemeester approved these changes Oct 31, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023

chmouel force-pushed the issue-7296-usernamepassword-support-in-http-resolver branch from c9f92ad to 724f260 Compare November 6, 2023 08:09

chmouel force-pushed the issue-7296-usernamepassword-support-in-http-resolver branch from 724f260 to 64d3ee4 Compare November 7, 2023 07:51

Yongxuanzhang reviewed Nov 7, 2023

View reviewed changes

jerop modified the milestones: Pipelines v0.54, Pipelines v0.55 Nov 9, 2023

chmouel force-pushed the issue-7296-usernamepassword-support-in-http-resolver branch from 64d3ee4 to c17dc30 Compare November 15, 2023 12:13

tekton-robot assigned Yongxuanzhang Nov 15, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023

tekton-robot merged commit 14d5a10 into tektoncd:main Nov 15, 2023

chmouel deleted the issue-7296-usernamepassword-support-in-http-resolver branch November 16, 2023 07:11

Conversation

chmouel commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

tekton-robot commented Oct 31, 2023

Uh oh!

tekton-robot commented Oct 31, 2023

Uh oh!

tekton-robot commented Oct 31, 2023

Uh oh!

tekton-robot commented Oct 31, 2023

Uh oh!

tekton-robot commented Oct 31, 2023

Uh oh!

tekton-robot commented Nov 6, 2023

Uh oh!

tekton-robot commented Nov 6, 2023

Uh oh!

tekton-robot commented Nov 7, 2023

Uh oh!

tekton-robot commented Nov 7, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Yongxuanzhang Nov 7, 2023

Choose a reason for hiding this comment

Uh oh!

tekton-robot commented Nov 15, 2023

Uh oh!

tekton-robot commented Nov 15, 2023

Uh oh!

Yongxuanzhang commented Nov 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chmouel commented Oct 31, 2023 •

edited

Loading