fix: panic may occur when calculating the final task timeout waiting time#7188
fix: panic may occur when calculating the final task timeout waiting time#7188tekton-robot merged 1 commit intotektoncd:mainfrom
Conversation
|
Hi @cugykw. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/kind bug |
|
/ok-to-test |
|
/test check-pr-has-kind-label |
|
@vdemeester: The specified target(s) for
The following commands are available to trigger optional jobs:
Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4aff897 to
2ba3835
Compare
2ba3835 to
5cb9498
Compare
|
/assign @jerop @pritidesai |
When I was troubleshooting this issue: #7185, I also found another problem. Determining the final task timeout waiting time may cause panic
If you set the pipelinerun finally timeout and also set the pipeline timeout to
0s, this will cause the program to panic.Changes
This commit no functional changes, it will avoid the panic caused by the above scenario.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind bug