Hide e2e test's example_test under a build tag#711
Merged
tekton-robot merged 1 commit intotektoncd:masterfrom Apr 2, 2019
Merged
Hide e2e test's example_test under a build tag#711tekton-robot merged 1 commit intotektoncd:masterfrom
tekton-robot merged 1 commit intotektoncd:masterfrom
Conversation
This removes the global `t` variable from the e2e test builds Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
googlebot
added
the
cla: yes
tekton-robot
added
approved
Member
Author
|
/test pull-tekton-pipeline-integration-tests |
Contributor
|
/lgtm |
Collaborator
|
@vdemeester will the CI still run this test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This removes the global
tvariable from the e2e test builds. Bonus : it stills appears ingodoc💃It's a follow-up of #702 cc @bobcatfish @abayer
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
[ ] Includes docs (if user facing)See the contribution guide
for more details.