Skip to content

Move and update v1beta1 to v1 migration doc from Indexed#5466

Merged
tekton-robot merged 2 commits intotektoncd:mainfrom
JeromeJu:5330-v1-migration-doc
Sep 15, 2022
Merged

Move and update v1beta1 to v1 migration doc from Indexed#5466
tekton-robot merged 2 commits intotektoncd:mainfrom
JeromeJu:5330-v1-migration-doc

Conversation

@JeromeJu
Copy link
Member

@JeromeJu JeromeJu commented Sep 9, 2022

Changes

This commit follows up on #5415 and resolves the respective examples and docs on the migration.

Fixes: #5330
/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • [n/a] Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

The document has been added that describes the changes needed when migrating from v1beta1 to v1.

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 9, 2022
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 9, 2022
@JeromeJu
Copy link
Member Author

JeromeJu commented Sep 9, 2022

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 9, 2022
This commit follows up on tektoncd#5415 and resolves the respective comments.
@JeromeJu JeromeJu force-pushed the 5330-v1-migration-doc branch from 0df2405 to fe5cab8 Compare September 9, 2022 21:02
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also move this document elsewhere for the time being ?
If we were to release tomorrow, a new page would appear (Migrating from v1beta1) which would be a bit confusing as it would make it look like v1 is already available, when it is not yet the case.

@JeromeJu
Copy link
Member Author

JeromeJu commented Sep 12, 2022

Can we also move this document elsewhere for the time being ? If we were to release tomorrow, a new page would appear (Migrating from v1beta1) which would be a bit confusing as it would make it look like v1 is already available, when it is not yet the case.

@vdemeester Thanks for the comment. May I ask where would be a good place to put it or shall I just remove it at the moment ?

@vdemeester
Copy link
Member

Can we also move this document elsewhere for the time being ? If we were to release tomorrow, a new page would appear (Migrating from v1beta1) which would be a bit confusing as it would make it look like v1 is already available, when it is not yet the case.

@vdemeester Thanks for the comment. May I ask where would be a good place to put it or shall I just remove it at the moment ?

Hum we definitely shouldn't remove it. Maybe in a dev/docs or anywhere that is not "indexed" by our website.

@JeromeJu JeromeJu requested review from vdemeester and removed request for afrittoli September 12, 2022 14:56
@JeromeJu
Copy link
Member Author

/retest

1 similar comment
@JeromeJu
Copy link
Member Author

/retest

@lbernick
Copy link
Member

Created #5478 for the test flakes on this PR

@JeromeJu JeromeJu changed the title Fix v1beta1 to v1 migration doc Move and update v1beta1 to v1 migration doc from Indexed Sep 13, 2022
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2022
@tekton-robot tekton-robot merged commit 9ecf023 into tektoncd:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1beta1 -> v1 migration guide

4 participants