Add conversion for v1 PipelineRun#5426
Merged
tekton-robot merged 1 commit intotektoncd:mainfrom Sep 6, 2022
Merged
Conversation
tekton-robot
added
release-note-none
tekton-robot
added
the
size/XL
Collaborator
|
The following is the coverage report on the affected files.
|
lbernick
approved these changes
Sep 6, 2022
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This commit adds conversion functions between v1beta1 and v1 PipelineRun. It implements ConvertTo and ConvertFrom for v1beta1 PipelineRun, and leaves these functions unimplemented for v1 PipelineRun, since it is the highest known version. It hasn't handled the deprecated `bundle` field but has handled the `resources` deprecation.
JeromeJu
force-pushed
the
4987-conversion
branch
from
9b2e796 to
42e8417
Compare
JeromeJu
requested review from
lbernick
and removed request for
dlorenc and
imjasonh
Collaborator
|
The following is the coverage report on the affected files.
|
Member
Author
|
/retest |
Contributor
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This commit adds conversion functions between v1beta1 and v1 PipelineRun.
It implements ConvertTo and ConvertFrom for v1beta1 PipelineRun, and leaves
these functions unimplemented for v1 PipelineRun, since it is the highest known version.
It hasn't handled the deprecated
bundlefield but has handled theresourcesdeprecation.part of #4987
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes