Add V1 Pipeline Golang structs by JeromeJu · Pull Request #5219 · tektoncd/pipeline

JeromeJu · 2022-07-26T17:53:46Z

Changes

This commit adds structs and validation for v1 Pipeline, including when expressions,
resultRef. This is copied from v1beta1 with the following exceptions:

omitted PipelineResources
omitted Bundle and ClusterTask fields
change PipelineTask whenExpressions Go field name from to When
due to api naming violation

Part of #4986
/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

[n/a] Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[n/a] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

tekton-robot · 2022-07-26T17:53:47Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

pkg/apis/pipeline/v1/resultref.go

lbernick · 2022-07-26T19:04:01Z

We do need to keep our alpha fields around (including matrix); they should just stay behind an alpha feature flag. the v1 TEP is the source of truth for what should be in the v1 api

tekton-robot · 2022-07-27T16:47:49Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	97.1%	94.5%	-2.6
pkg/apis/pipeline/v1/pipeline_defaults.go	Do not exist	0.0%
pkg/apis/pipeline/v1/pipeline_types.go	Do not exist	94.5%
pkg/apis/pipeline/v1/pipeline_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/resultref.go	Do not exist	87.3%
pkg/apis/pipeline/v1/status_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskref_validation.go	Do not exist	0.0%
pkg/apis/pipeline/v1/when_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_validation.go	Do not exist	100.0%

pkg/apis/pipeline/v1/pipeline_types_test.go

tekton-robot · 2022-07-27T17:18:30Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	97.1%	94.5%	-2.6
pkg/apis/pipeline/v1/pipeline_defaults.go	Do not exist	0.0%
pkg/apis/pipeline/v1/pipeline_types.go	Do not exist	94.5%
pkg/apis/pipeline/v1/pipeline_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/resultref.go	Do not exist	87.3%
pkg/apis/pipeline/v1/status_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskref_validation.go	Do not exist	0.0%
pkg/apis/pipeline/v1/when_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_validation.go	Do not exist	100.0%

tekton-robot · 2022-07-27T18:00:16Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	97.1%	94.5%	-2.6
pkg/apis/pipeline/v1/pipeline_defaults.go	Do not exist	0.0%
pkg/apis/pipeline/v1/pipeline_types.go	Do not exist	94.5%
pkg/apis/pipeline/v1/pipeline_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/resultref.go	Do not exist	87.3%
pkg/apis/pipeline/v1/status_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskref_validation.go	Do not exist	0.0%
pkg/apis/pipeline/v1/when_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_validation.go	Do not exist	100.0%

pkg/apis/pipeline/v1/pipeline_types_test.go

pkg/apis/pipeline/v1/pipeline_types.go

pkg/apis/pipeline/v1/taskref_types.go

lbernick · 2022-07-27T18:05:26Z

pkg/apis/pipeline/v1/status_validation.go

+
+// ValidateEmbeddedStatus checks that the embedded-status feature gate is set to the wantEmbeddedStatus value and,
+// if not, returns an error stating which feature is dependent on the status and what the current status actually is.
+func ValidateEmbeddedStatus(ctx context.Context, featureName, wantEmbeddedStatus string) *apis.FieldError {


this file shouldn't be needed for Pipeline (only relevant to PipelineRun)

It seems that this is used in the call stack for validateMatrix, which calls the following func:
https://github.com/JeromeJu/pipeline/blob/5e7bc86121ed814b7066b57d5686b5338326abcd/pkg/apis/pipeline/v1/pipeline_types.go#L289

Got it that makes sense! In v1, we will only allow this feature flag to be set to "minimal". I think this is OK to stay, but we should also add a similar validation function for PipelineRun (not in this PR) that prevents a v1 PipelineRun from being created unless the feature flag is set to "minimal".

Thanks Lee. I've noted this down and will be applying to the PipelineRun change which I'd also like to take after this PR and related work.
#4987

lbernick · 2022-07-27T18:09:48Z

Shall we exclude the files generated by ./hack/update-codegen.sh under pkg/client?

No, these files are code generated by knative, which we need

tekton-robot · 2022-07-27T21:42:00Z

@JeromeJu: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-tekton-pipeline-alpha-integration-tests
/test pull-tekton-pipeline-build-tests
/test pull-tekton-pipeline-integration-tests
/test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

/test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

Details

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2022-07-28T12:57:15Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	97.1%	94.5%	-2.6
pkg/apis/pipeline/v1/pipeline_defaults.go	Do not exist	0.0%
pkg/apis/pipeline/v1/pipeline_types.go	Do not exist	93.1%
pkg/apis/pipeline/v1/pipeline_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/resultref.go	Do not exist	72.7%
pkg/apis/pipeline/v1/status_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskref_validation.go	Do not exist	0.0%
pkg/apis/pipeline/v1/when_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_validation.go	Do not exist	100.0%

tekton-robot · 2022-07-28T18:54:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	97.1%	94.5%	-2.6
pkg/apis/pipeline/v1/pipeline_defaults.go	Do not exist	0.0%
pkg/apis/pipeline/v1/pipeline_types.go	Do not exist	93.1%
pkg/apis/pipeline/v1/pipeline_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/resultref.go	Do not exist	72.7%
pkg/apis/pipeline/v1/status_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskref_validation.go	Do not exist	0.0%
pkg/apis/pipeline/v1/when_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_validation.go	Do not exist	100.0%

tekton-robot · 2022-07-28T19:56:25Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	97.1%	94.5%	-2.6
pkg/apis/pipeline/v1/pipeline_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/pipeline_types.go	Do not exist	93.1%
pkg/apis/pipeline/v1/pipeline_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/resultref.go	Do not exist	72.7%
pkg/apis/pipeline/v1/status_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskref_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_validation.go	Do not exist	100.0%

tekton-robot · 2022-07-28T23:42:02Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	97.1%	96.3%	-0.8
pkg/apis/pipeline/v1/pipeline_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/pipeline_types.go	Do not exist	95.1%
pkg/apis/pipeline/v1/pipeline_validation.go	Do not exist	99.4%
pkg/apis/pipeline/v1/resultref.go	Do not exist	98.2%
pkg/apis/pipeline/v1/status_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskref_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_validation.go	Do not exist	100.0%

tekton-robot · 2022-07-29T12:30:21Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	97.1%	96.3%	-0.8
pkg/apis/pipeline/v1/pipeline_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/pipeline_types.go	Do not exist	95.1%
pkg/apis/pipeline/v1/pipeline_validation.go	Do not exist	99.4%
pkg/apis/pipeline/v1/resultref.go	Do not exist	98.2%
pkg/apis/pipeline/v1/status_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskref_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_validation.go	Do not exist	100.0%

tekton-robot · 2022-07-29T12:35:24Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	97.1%	96.3%	-0.8
pkg/apis/pipeline/v1/pipeline_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/pipeline_types.go	Do not exist	95.1%
pkg/apis/pipeline/v1/pipeline_validation.go	Do not exist	99.4%
pkg/apis/pipeline/v1/resultref.go	Do not exist	98.2%
pkg/apis/pipeline/v1/status_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskref_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_validation.go	Do not exist	100.0%

pkg/apis/pipeline/v1/pipeline_types.go

pkg/apis/pipeline/v1/taskref_types.go

tekton-robot · 2022-07-29T21:04:15Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	97.1%	96.3%	-0.8
pkg/apis/pipeline/v1/pipeline_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/pipeline_types.go	Do not exist	95.1%
pkg/apis/pipeline/v1/pipeline_validation.go	Do not exist	99.4%
pkg/apis/pipeline/v1/resultref.go	Do not exist	98.2%
pkg/apis/pipeline/v1/status_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskref_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_validation.go	Do not exist	100.0%

tekton-robot · 2022-07-29T21:13:24Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	97.1%	96.3%	-0.8
pkg/apis/pipeline/v1/pipeline_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/pipeline_types.go	Do not exist	95.1%
pkg/apis/pipeline/v1/pipeline_validation.go	Do not exist	99.4%
pkg/apis/pipeline/v1/resultref.go	Do not exist	98.2%
pkg/apis/pipeline/v1/status_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskref_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_validation.go	Do not exist	100.0%

tekton-robot · 2022-07-29T22:35:35Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	97.1%	96.3%	-0.8
pkg/apis/pipeline/v1/pipeline_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/pipeline_types.go	Do not exist	95.1%
pkg/apis/pipeline/v1/pipeline_validation.go	Do not exist	99.4%
pkg/apis/pipeline/v1/resultref.go	Do not exist	98.2%
pkg/apis/pipeline/v1/status_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskref_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_validation.go	Do not exist	100.0%

tekton-robot · 2022-08-02T13:17:24Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	97.1%	96.3%	-0.8
pkg/apis/pipeline/v1/pipeline_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/pipeline_types.go	Do not exist	95.1%
pkg/apis/pipeline/v1/pipeline_validation.go	Do not exist	99.4%
pkg/apis/pipeline/v1/resultref.go	Do not exist	98.2%
pkg/apis/pipeline/v1/status_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskref_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_validation.go	Do not exist	100.0%

lbernick

Thanks Jerome! could you please:

update the PR description to specify that the Go field name for When was changed, not the API
add a commit message body
double check whether there have been any changes to pkg/apis affecting these files since you opened this PR, and make sure they're incorporated here?

tekton-robot · 2022-08-02T15:16:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [lbernick]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This commit adds structs and validation for v1 Pipeline, including when expressions, resultRef. This is copied from v1beta1 with the following exceptions: - omitted PipelineResources - omitted Bundle and ClusterTask fields - change PipelineTask `whenExpressions` Go field name from to `When` due to api naming violation

tekton-robot · 2022-08-02T15:49:39Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/param_types.go	97.1%	96.3%	-0.8
pkg/apis/pipeline/v1/pipeline_defaults.go	Do not exist	100.0%
pkg/apis/pipeline/v1/pipeline_types.go	Do not exist	95.1%
pkg/apis/pipeline/v1/pipeline_validation.go	Do not exist	99.4%
pkg/apis/pipeline/v1/resultref.go	Do not exist	98.2%
pkg/apis/pipeline/v1/status_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/taskref_validation.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_types.go	Do not exist	100.0%
pkg/apis/pipeline/v1/when_validation.go	Do not exist	100.0%

JeromeJu · 2022-08-02T16:00:25Z

Thanks Jerome! could you please:

update the PR description to specify that the Go field name for When was changed, not the API

add a commit message body

double check whether there have been any changes to pkg/apis affecting these files since you opened this PR, and make sure they're incorporated here?

Thanks Lee:) Updated.

jerop · 2022-08-02T19:08:05Z

/assign

jerop

/lgtm

JeromeJu · 2022-08-08T15:01:39Z

/retest

pkg/apis/pipeline/v1/pipeline_types.go

tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 26, 2022

tekton-robot requested review from jerop and lbernick July 26, 2022 17:53

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 26, 2022

lbernick self-assigned this Jul 26, 2022

JeromeJu commented Jul 26, 2022

View reviewed changes

pkg/apis/pipeline/v1/resultref.go Show resolved Hide resolved

dibyom mentioned this pull request Jul 26, 2022

[TEP-0104] Populate Task-level Resource Requirements from PipelineRun to TaskRun #5212

Merged

7 tasks

JeromeJu force-pushed the 4986-v1-pipeline branch from 1a25116 to 789e247 Compare July 27, 2022 15:08

tekton-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 27, 2022

JeromeJu commented Jul 27, 2022

View reviewed changes

pkg/apis/pipeline/v1/pipeline_types_test.go Outdated Show resolved Hide resolved

lbernick reviewed Jul 27, 2022

View reviewed changes

JeromeJu changed the title ~~[WIP] Add V1 Pipeline Golang structs~~ Add V1 Pipeline Golang structs Jul 27, 2022

tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 28, 2022

JeromeJu mentioned this pull request Jul 28, 2022

V1 version of PipelineRun #4987

Closed

JeromeJu marked this pull request as ready for review July 28, 2022 23:37

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2022

tekton-robot requested review from abayer and imjasonh July 28, 2022 23:37

JeromeJu force-pushed the 4986-v1-pipeline branch from 471bb2a to 6045eb7 Compare July 29, 2022 12:30

tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 29, 2022

lbernick reviewed Jul 29, 2022

View reviewed changes

pkg/apis/pipeline/v1/pipeline_types.go Outdated Show resolved Hide resolved

pkg/apis/pipeline/v1/pipeline_types.go Outdated Show resolved Hide resolved

pkg/apis/pipeline/v1/taskref_types.go Show resolved Hide resolved

pkg/apis/pipeline/v1/taskref_types.go Outdated Show resolved Hide resolved

lbernick mentioned this pull request Aug 1, 2022

Move parameter validation from taskspec to taskrunspec when propagating parameters #5143

Merged

7 tasks

JeromeJu force-pushed the 4986-v1-pipeline branch from 2286532 to ac1113e Compare August 2, 2022 13:12

lbernick approved these changes Aug 2, 2022

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022

JeromeJu force-pushed the 4986-v1-pipeline branch from ac1113e to f8526e5 Compare August 2, 2022 15:44

JeromeJu mentioned this pull request Aug 2, 2022

Put all pkg/apis/pipeline/v1beta1/*_test.go files to v1beta1_test package #5111

Open

JeromeJu mentioned this pull request Aug 2, 2022

Add conversion for v1 Pipeline #5258

Merged

6 tasks

tekton-robot assigned jerop Aug 2, 2022

jerop reviewed Aug 8, 2022

View reviewed changes

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022

tekton-robot merged commit 05fedfd into tektoncd:main Aug 8, 2022

JeromeJu mentioned this pull request Aug 23, 2022

Emit warning or error for creation of v1 PipelineRun with "full" or "both" embedded status #5355

Closed

afrittoli reviewed Sep 2, 2022

View reviewed changes

pkg/apis/pipeline/v1/pipeline_types.go Show resolved Hide resolved

JeromeJu mentioned this pull request Sep 2, 2022

Restore results dependencies in v1 Pipeline #5424

Merged

4 tasks

Conversation

JeromeJu commented Jul 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

tekton-robot commented Jul 26, 2022

Uh oh!

Uh oh!

lbernick commented Jul 26, 2022

Uh oh!

tekton-robot commented Jul 27, 2022

Uh oh!

Uh oh!

tekton-robot commented Jul 27, 2022

Uh oh!

tekton-robot commented Jul 27, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lbernick Jul 27, 2022

Choose a reason for hiding this comment

Uh oh!

JeromeJu Jul 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lbernick Jul 28, 2022

Choose a reason for hiding this comment

Uh oh!

JeromeJu Jul 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lbernick commented Jul 27, 2022

Uh oh!

tekton-robot commented Jul 27, 2022

Uh oh!

tekton-robot commented Jul 28, 2022

Uh oh!

tekton-robot commented Jul 28, 2022

Uh oh!

tekton-robot commented Jul 28, 2022

Uh oh!

tekton-robot commented Jul 28, 2022

Uh oh!

tekton-robot commented Jul 29, 2022

Uh oh!

tekton-robot commented Jul 29, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Jul 29, 2022

Uh oh!

tekton-robot commented Jul 29, 2022

Uh oh!

tekton-robot commented Jul 29, 2022

Uh oh!

tekton-robot commented Aug 2, 2022

Uh oh!

lbernick left a comment

Choose a reason for hiding this comment

Uh oh!

tekton-robot commented Aug 2, 2022

Uh oh!

tekton-robot commented Aug 2, 2022

Uh oh!

JeromeJu commented Aug 2, 2022

Uh oh!

jerop commented Aug 2, 2022

Uh oh!

jerop left a comment

Choose a reason for hiding this comment

Uh oh!

JeromeJu commented Aug 8, 2022

JeromeJu commented Jul 26, 2022 •

edited

Loading

JeromeJu Jul 27, 2022 •

edited

Loading

JeromeJu Jul 28, 2022 •

edited

Loading