Refactor input resource volume handling to remove a type switch state…#1139
Refactor input resource volume handling to remove a type switch state…#1139tekton-robot merged 1 commit intotektoncd:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
googlebot
added
the
cla: yes
tekton-robot
added
approved
|
The following is the coverage report on pkg/.
|
…ment. This change refactors the way input resources attach volumes to their steps. Previously, there was a special-cased switch statement for Storage type resources. This made the logic for resources hard to follow, and spread across the codebase. This change refactors that by moving it up into the general Resource interface. This is another follow-on to tektoncd#1135
|
The following is the coverage report on pkg/.
|
| } | ||
|
|
||
| func (s *BuildGCSResource) GetDownloadVolumeSpec(spec *TaskSpec) ([]corev1.Volume, error) { | ||
| return getStorageUploadVolumeSpec(s, spec) |
There was a problem hiding this comment.
v minor but would renaming to getStorageTransferVolumeSpec or maybe even just getStorageVolumeSpec or similar make sense given this is now also being used for the download volume?
afrittoli
left a comment
afrittoli
left a comment
There was a problem hiding this comment.
Thank you for this!
Since this is an extension of the API it shouldn't have any impact on any of the known consumers.
| return nil, xerrors.Errorf("task %q invalid resource download spec: %q; error %w", taskName, boundResource.ResourceRef.Name, err) | ||
| } | ||
| } | ||
| resourceContainers, err = resource.GetDownloadContainerSpec() |
There was a problem hiding this comment.
Nice, I'm not sure why this was part of the addStorageFetchStep to begin with.
| taskSpec.Steps = append(copyStepsFromPrevTasks, taskSpec.Steps...) | ||
| taskSpec.Volumes = append(taskSpec.Volumes, as.GetSecretsVolumes()...) | ||
| } else { | ||
| switch resource.GetType() { |
There was a problem hiding this comment.
So happy to see this switch go away :)
|
/lgtm |
4 participants
…ment.
Changes
This change refactors the way input resources attach volumes to their steps.
Previously, there was a special-cased switch statement for Storage type resources.
This made the logic for resources hard to follow, and spread across the codebase. This
change refactors that by moving it up into the general Resource interface.
This is another follow-on to #1135
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.