TEP-0157 Retention Policy for Tekton Results

[khrm]

No description provided.

[tekton-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from khrm after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• teps/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[khrm]

/kind tep

[khrm]

/test pull-community-teps-lint

[tekton-robot]

@khrm: No presubmit jobs available for tektoncd/community@main

Details

In response to this:

/test pull-community-teps-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[khrm]

/assign @avinal @enarha @sayan-biswas

[khrm]

/assign @vdemeester

[amir-badar]

@khrm I wanna know if the retention policy under TektonResults component is configurable via TektonConfig CR? Like this

result:
    disabled: false
    is_external_db: false
    options:
      configMaps:
        config-results-retention-policy:
          data:
            runAt: "5 5 * * 0"
            maxRetention: "15"

This RedHat openshift doc here says that we can set maxRetention field this way.

[khrm]

@amir-badar Yes, it's configurable using that, but we are changing maxRetention to defautlRetention. maxRetention will still work, but it's deprecated.

[enarha]

One thing I find missing is how the deletion of logs happens. The TEP explains how data is deleted from the DB, please add a short description how that's connected to the logs deletion.
The rest is LGTM.

[khrm]

@enarha Sure. I would add that part also.