Skip to content

Conversation

@elianiva
Copy link
Member

baru kali ini nulis regex banyak banyak

@elianiva elianiva linked an issue Aug 20, 2021 that may be closed by this pull request
@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2021

This pull request introduces 3 alerts when merging 454db47 into 051d272 - view on LGTM.com

new alerts:

  • 3 for Inefficient regular expression

@elianiva
Copy link
Member Author

hmm, bisa ngga ya kalo begitu tau dia itu comment, seterusnya bakal diignore
biar ga dapet false positive, keknya ga bisa deh kalo udah mulai multiline gitu

di luajit juga ada ffi, kode ini bisa bisa kebaca jadi C

ffi.cdef([[
  typedef struct s_mmbuffer { const char *ptr; long size; } mmbuffer_t;

  typedef struct s_xpparam {
    unsigned long flags;

    // See Documentation/diff-options.txt.
    char **anchors;
    size_t anchors_nr;
  } xpparam_t;

  typedef long (__stdcall *find_func_t)(
    const char *line,
    long line_len,
    char *buffer,
    long buffer_size,
    void *priv
  );

  typedef int (__stdcall *xdl_emit_hunk_consume_func_t)(
    long start_a, long count_a, long start_b, long count_b,
    void *cb_data
  );
]]

@aldy505
Copy link
Member

aldy505 commented Aug 20, 2021

hmm, bisa ngga ya kalo begitu tau dia itu comment, seterusnya bakal diignore
biar ga dapet false positive, keknya ga bisa deh kalo udah mulai multiline gitu

kalo algo sekarang harusnya bisa. dia tambahin poin caranya dengan baca per line ada yang match atau engga.

@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@051d272). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master       #26   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        18           
  Lines             ?       737           
  Branches          ?        46           
==========================================
  Hits              ?       737           
  Misses            ?         0           
  Partials          ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 051d272...c426bfd. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Aug 23, 2021

This pull request introduces 3 alerts when merging c426bfd into 1bc4ceb - view on LGTM.com

new alerts:

  • 3 for Inefficient regular expression

@aldy505 aldy505 merged commit 60864b1 into master Aug 23, 2021
@aldy505 aldy505 deleted the feat/lua branch August 23, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new language: Lua

3 participants