Skip to content

Conversation

MichaelSun90
Copy link
Contributor

This should resolve #1557
create a new Error subclass (maybe called ParameterValidationError), have it inherit from whatever error class we currently use (that might be TypeError, but I'm not sure), and define the additional properties on that.

User will have access to the param name and param value information via both message and error properties.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.51%. Comparing base (4f3e210) to head (bf2b891).
⚠️ Report is 51 commits behind head on master.

Files with missing lines Patch % Lines
src/connection.ts 0.00% 10 Missing ⚠️
src/request.ts 0.00% 4 Missing ⚠️
src/errors.ts 0.00% 3 Missing ⚠️
src/bulk-load.ts 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (4f3e210) and HEAD (bf2b891). Click for more details.

HEAD has 72 uploads less than BASE
Flag BASE (4f3e210) HEAD (bf2b891)
86 14
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1566       +/-   ##
===========================================
- Coverage   80.45%   54.51%   -25.95%     
===========================================
  Files          92       92               
  Lines        4692     4700        +8     
  Branches      871      871               
===========================================
- Hits         3775     2562     -1213     
- Misses        644     1889     +1245     
+ Partials      273      249       -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MichaelSun90 MichaelSun90 changed the title feature: add new error type for param validation feat: add new error type for param validation Aug 8, 2023
@MichaelSun90
Copy link
Contributor Author

@arthurschreiber , do we need to worry about this new parameter validation error will review some sensitive information that user may insert within their column, since we are expose the parameter values via this error?

@MichaelSun90
Copy link
Contributor Author

Create a new PR for test these error related, then use the test test against this current changes within this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor addition to exception information on failed bulk-load data due to type validation: Mention the failed column and errorneous value
1 participant