Skip to content

Fix/open accordion from url #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sebbalex merged 4 commits into from
Feb 21, 2022
Merged

Fix/open accordion from url #310

sebbalex merged 4 commits into from
Feb 21, 2022

Conversation

@emnlpstr
Copy link
Collaborator

@emnlpstr emnlpstr commented Feb 18, 2022

fixed open accordion and select filter from url

@sebbalex
Copy link
Contributor

sebbalex commented Feb 21, 2022

We need to be very careful here, using same page for multiple anchor types, derived from different sources can cause conflicts if same key is used.
cc @lollomag @emnlpstr

@sebbalex sebbalex changed the base branch from develop to main February 21, 2022 14:52
@sebbalex sebbalex merged commit a26fca7 into main Feb 21, 2022
@sebbalex sebbalex deleted the fix/open-accordion-from-url branch February 21, 2022 15:00
@sebbalex sebbalex mentioned this pull request Feb 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lollomag lollomag lollomag approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emnlpstr @sebbalex @lollomag