Disable Rack::Protection::HostAuthorization
#2812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rack::Protection 4.1.0 has introduced new `Rack::Protection::HostAuthorization` [[1]]. This makes `www.example.com` host to be rejected. The easiest solution is to disable this check for the TestApp. [1]: sinatra/sinatra#2053
|
Thanks, merged into the ci branch for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rack::Protection 4.1.0 has introduced new
Rack::Protection::HostAuthorization[1]. This makeswww.example.comhost to be rejected. The easiest solution is to disable this check for the TestApp.The
permitted_hostscould be more elaborated, e.g.set :host_authorization, { permitted_hosts: [".example.com", "127.0.0.1"] }also helped. While it seems weird to me, the127.0.0.1needs to be included to pass the test in spec/session/current_url_spec.rb 🤷I have also tested this PR against Sinatra / Rack::Protection 4.0.1 and the "unknown"
:host_authorizationdoes not seem to cause any troubles.This should help address issues observed in #2811