Address warning: URI::RFC3986_PARSER.make_regexp is obsoleted. warning
#2781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RI::RFC2396_PARSER.make_regexp explicitly.` warning This commit addresses `warning: URI::RFC3986_PARSER.make_regexp is obsoleted. Use URI::RFC2396_PARSER.make_regexp explicitly.` warning Ruby 3.4 changes URI::DEFAULT_PARSER to URI::RFC3986_Parser and deprecates URI::RFC3986_PARSER.make_regexp. This commit uses `URI::RFC2396_PARSER` only if it is available for these versions: - `uri` v0.12.2 for Ruby 3.2/3.1 - `uri` v0.13.1 for Ruby 3.3 - Ruby 3.4.0dev Fix teamcapybara#2778 Refer https://bugs.ruby-lang.org/issues/19266
|
@twalpole Sorry to be a bother, but could a maintainer merge and release this change? That waring is quite annoying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses
warning: URI::RFC3986_PARSER.make_regexp is obsoleted. Use URI::RFC2396_PARSER.make_regexp explicitly.warningRuby 3.4 changes URI::DEFAULT_PARSER to URI::RFC3986_Parser and deprecates URI::RFC3986_PARSER.make_regexp.
This commit uses
URI::RFC2396_PARSERonly if it is available for these versions:uriv0.12.2 for Ruby 3.2/3.1uriv0.13.1 for Ruby 3.3Fix #2778
Refer https://bugs.ruby-lang.org/issues/19266