Merged
Conversation
minju1459
approved these changes
Jun 30, 2023
Member
minju1459
left a comment
minju1459
left a comment
There was a problem hiding this comment.
정말 수고하셨습니다!! 저도 추후에 이 코드들 토대로 서버 통신해보겠습니당 강멘 !!
b1urrrr
approved these changes
Jun 30, 2023
Comment on lines
+22
to
+23
| initView() | ||
| observe() |
Comment on lines
+29
to
+30
| <activity android:name=".presentation.yello.YelloActivity" | ||
| android:exported="false" /> |
Member
There was a problem hiding this comment.
Suggested change
| <activity android:name=".presentation.yello.YelloActivity" | |
| android:exported="false" /> | |
| <activity android:name=".presentation.yello.YelloActivity" | |
| android:screenOrientation="portrait" | |
| android:exported="false" /> |
가로 막아버리는 거 어떤가여
Contributor
Author
There was a problem hiding this comment.
사실 내 뷰 아마도 fragment라서 이거 임시 액티비티! @b1urrrr
Comment on lines
+13
to
+33
| interface YelloService { | ||
| @GET("yello") | ||
| suspend fun getMyYelloList( | ||
| @Query("page") page: Int | ||
| ): BaseResponse<ResponseMyYello> | ||
|
|
||
| @GET("yello/{id}/name") | ||
| suspend fun getYelloDetail( | ||
| @Path("id") id: Long | ||
| ): BaseResponse<ResponseYelloDetail> | ||
|
|
||
| @POST("yello/{id}/keyword") | ||
| suspend fun checkKeyword( | ||
| @Path("id") id: Long | ||
| ): BaseResponse<ResponseCheckKeyword> | ||
|
|
||
| @POST("yello/{id}/name") | ||
| suspend fun checkName( | ||
| @Path("id") id: Long | ||
| ): BaseResponse<ResponseCheckName> | ||
| } No newline at end of file |
Comment on lines
+22
to
+32
| private val _myYelloData = MutableStateFlow<UiState<MyYello>>(UiState.Loading) | ||
| val myYelloData: StateFlow<UiState<MyYello>> = _myYelloData.asStateFlow() | ||
|
|
||
| private val _yelloDetailData = MutableStateFlow<UiState<YelloDetail>>(UiState.Loading) | ||
| val yelloDetailData: StateFlow<UiState<YelloDetail>> = _yelloDetailData.asStateFlow() | ||
|
|
||
| private val _keywordData = MutableStateFlow<UiState<CheckKeyword>>(UiState.Loading) | ||
| val keywordData: StateFlow<UiState<CheckKeyword>> = _keywordData.asStateFlow() | ||
|
|
||
| private val _nameData = MutableStateFlow<UiState<CheckName>>(UiState.Loading) | ||
| val nameData: StateFlow<UiState<CheckName>> = _nameData.asStateFlow() |
Comment on lines
+16
to
+23
| fun getUiStateModel(): UiStateModel { | ||
| return UiStateModel( | ||
| this is Empty, | ||
| this is Loading, | ||
| this is Success, | ||
| this is Failure | ||
| ) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@b1urrrr 이거 나중에 Ui랑 databinding으로 묶어서 한번에 처리하는 마술 보여줄게용
Collaborator
|
즐거워 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📢 To Reviewers