Skip to content

[UI/#18] Yello / 옐로 뷰 UI 구현#31

Merged
b1urrrr merged 34 commits intodevelopfrom
ui/#18-yello-view
Jul 14, 2023
Merged

[UI/#18] Yello / 옐로 뷰 UI 구현#31
b1urrrr merged 34 commits intodevelopfrom
ui/#18-yello-view

Conversation

@b1urrrr
Copy link
Copy Markdown
Member

@b1urrrr b1urrrr commented Jul 14, 2023

⛳️ Work Description

  • 옐로 뷰 레이아웃 구현
  • 투표뷰 기본 동작 구현

📸 Screenshot

Yello

Start Wait Lock

Vote

Android.Emulator.-.Galaxy_S21_API_31_5554.2023-07-14.14-39-59.mp4

📢 To Reviewers

  • 스낵바랑 타이머, 카카오톡 친구 연결 창, 말풍도 마저 구현하겟슴당
  • pr이 너무 커져서 미안해여 그렇게 됐습니다

b1urrrr added 28 commits July 9, 2023 00:25
@b1urrrr b1urrrr added PULL REQUEST 🚀 pull reqeust 날리기 UI 💐 UI 작업 labels Jul 14, 2023
@b1urrrr b1urrrr added the 채연 🐸 Chaeyeon's Task label Jul 14, 2023
@b1urrrr b1urrrr added this to the UI 구현 milestone Jul 14, 2023
@b1urrrr b1urrrr requested a review from a team as a code owner July 14, 2023 05:48
@b1urrrr b1urrrr self-assigned this Jul 14, 2023
@b1urrrr b1urrrr changed the title [UI/#18] yello / 옐로 뷰 UI 구현 [UI/#18] Yello / 옐로 뷰 UI 구현 Jul 14, 2023
Copy link
Copy Markdown
Member

@Marchbreeze Marchbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고칠게 없네용 ... 완벽티비

else -> R.drawable.img_note_face10
},
)
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

바인딩어댑터 배워갑니다...!

)
binding.layoutNoteProgressAfter.getChildAt(i - noteIndex - 1).rotation =
progressDegree[i]
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오와 돌리는거 신기하네요

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

천재시네요

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드로 예술을 하시네요 ...

Copy link
Copy Markdown
Contributor

@kkk5474096 kkk5474096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정말 완벽합니다..

)
binding.layoutNoteProgressAfter.getChildAt(i - noteIndex - 1).rotation =
progressDegree[i]
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

천재시네요

Comment on lines +68 to +71
val args = Bundle()
args.putInt(ARGS_NOTE_INDEX, index)
args.putInt(ARGS_BACKGROUND_INDEX, bgIndex)
arguments = args
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arguments = bundleOf(
 ARGS_NOTE_INDEX to index,
 ARGS_BACKGROUND_INDEX to bgIndex
)

이렇게도 사용 가능합니다~

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 가독성 미쳤네요!! 감삼다!

Copy link
Copy Markdown
Member

@minju1459 minju1459 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정말 수고 많으셨습니다 💛 리드님 LGTM💡

)
binding.layoutNoteProgressAfter.getChildAt(i - noteIndex - 1).rotation =
progressDegree[i]
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드로 예술을 하시네요 ...

@b1urrrr b1urrrr merged commit b3e079d into develop Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PULL REQUEST 🚀 pull reqeust 날리기 UI 💐 UI 작업 채연 🐸 Chaeyeon's Task

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants