Editorial: Remove no-op ValidateTemporalUnitValue call

[ptomato]

largestUnit can be any unit, AUTO, or UNSET here. ValidateTemporalUnitValue just checks if it is any unit, AUTO, or UNSET, so it's a no-op.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.78%. Comparing base (6964def) to head (b576c46).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3143      +/-   ##
==========================================
- Coverage   96.78%   96.78%   -0.01%     
==========================================
  Files          21       21              
  Lines       10003    10002       -1     
  Branches     1830     1830              
==========================================
- Hits         9681     9680       -1     
  Misses        276      276              
  Partials       46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sffc]

Suggestion: Simply this further by changing ValidateTemporalUnitValue to accept only ~date~ and ~time~, since this is the only call site for ~datetime~.

[ptomato]

Suggestion: Simply this further by changing ValidateTemporalUnitValue to accept only ~date~ and ~time~, since this is the only call site for ~datetime~.

It can still be called with DATETIME in GetDifferenceSettings so we still need to accept DATETIME to deal with the situation where all units are valid but "auto" is not.

[ptomato]

Thanks for the review!