Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2477 +/- ##
==========================================
+ Coverage 94.81% 94.94% +0.12%
==========================================
Files 20 20
Lines 10842 10821 -21
Branches 1972 1957 -15
==========================================
- Hits 10280 10274 -6
+ Misses 502 487 -15
Partials 60 60
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Aditi-1400
changed the title
Collaborator
|
I'll mark this as draft until it's presented in the TC39 plenary. |
Aditi-1400
force-pushed
the
temporal-2419
branch
from
f610aae to
e02f99e
Compare
ptomato
reviewed
Jan 17, 2023
Aditi-1400
force-pushed
the
temporal-2419
branch
from
e02f99e to
1032534
Compare
ptomato
approved these changes
Jan 18, 2023
Collaborator
|
This change achieved consensus at the TC39 plenary of 2023-01-31. It is already covered by test262 tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made changes to DifferenceInstant operation to prevent loss of precision.
The approach is to convert the nanoseconds into seconds, milliseconds ≤ 999, microseconds ≤ 999, and
nanoseconds ≤ 999 before passing those values to
RoundDuration.Fixes: #2419