-
Notifications
You must be signed in to change notification settings - Fork 114
Editorial: Update to ES2026 draft #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2713fcb to
b8ee556
Compare
gibson042
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as-is, but how would you feel about finally replacing all the es$YYYY references with something static like "ECMA-262" that links to a single <dfn> as the sole site that will need annual updating (presumably the one under Normative References right above the no-longer-needed emu-note)?
Yeah, sounds like a good idea although this wasn't a lot of work either with search and replace. |
|
For some reason in my local build the references aren't linked like I'd have expected them to be? Could you check out the second commit for any errors? Linter found nothing. |
gibson042
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added suggestions to replace all the ECMA-262, <emu-xref href="…"></emu-xref> instances with <emu-xref href="…" title></emu-xref>, which expands to the ECMA-262 section title. If you instead want to preserve the indication, feel free to disregard most or all of those (but I do in particular prefer not doing so in conventions.html). Or we could petition for a change in ecmarkup that supports e.g. <emu-xref href="…" title external="ECMA-262">.
The other changes (such as "ECMAScript 2026 Language Specification (ECMA-262 17th Edition, or successor)" → "ECMA-262") just make for cleaner rendering and easier maintenance.
|
Thanks for all the comments! Applied them all (needless to say I was happy with all proposed changes) and squashed them together. Pushing a few more as a separate commit, check them out and let me know if they look good and we could go ahead with this. Love how we took this mostly routine PR and managed to make a bunch of editorial improvements that'll make editors' lives easier. |
|
Sorry for the delay, there was only one strong contender so here it is. |
|
@gibson042 what do you feel about this last commit? If you're happy with that change I'll squash it into the previous one and merge this in. |
gibson042
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ryzokuken LGTM. Added one last suggestion.
Co-authored-by: Yuto Yoshino <[email protected]> Co-authored-by: Richard Gibson <[email protected]>
Rename all references to es202x to ECMA-262 with a dfn that could be updated more conveninently and get rid of redundant editorial note. Furthermore, it simplifies every remaining reference to ECMA-262 in the spec to be better and easier to maintain in the future. Co-authored-by: Richard Gibson <[email protected]>
Update references to ES 2026 and bump the version of the spec itself.