Normative: Add Intl.Locale.prototype.variants #960

gibson042 · 2025-02-14T17:26:25Z

Fixes #900

FrankYFTang · 2025-03-06T18:18:48Z

spec/locale.html

+        1. Perform ? RequireInternalSlot(_loc_, [[InitializedLocale]]).
+        1. Let _variantsString_ be GetLocaleVariants(_loc_.[[Locale]]).
+        1. Let _variantsList_ be StringSplitToList(_variantsString_, *"-"*).
+        1. Return CreateArrayFromList(_variantsList_).


@anba Should this also state the order need to be in alphabetical order ?
See the order discussion in
https://unicode.org/reports/tr35/#Canonical_Unicode_Locale_Identifiers

It might benefit from a note, but nothing more—alphabetization is already required by use of CanonicalizeUnicodeLocaleId in the Intl.Locale constructor.

FrankYFTang · 2025-03-06T18:59:37Z

If we do this, then how about setting variants in option bag them?

gibson042 · 2025-03-06T19:16:32Z

If we do this, then how about setting variants in option bag them?

Good question, and I think the answer is "yes". This also interacts with the design question about representing variants as an array of strings or as a single dash-separated string, and I'm increasingly inclined towards the latter.

sffc · 2025-03-10T07:29:45Z

TG2 discussion: https://github.com/tc39/ecma402/blob/main/meetings/notes-2025-03-06.md#normative-add-localeprototypegetvariants-960

sffc · 2025-04-03T21:05:54Z

TG2 discussion, focused on the motivation: https://github.com/tc39/ecma402/blob/main/meetings/notes-2025-04-03.md#normative-add-localeprototypegetvariants-960

spec/locale.html

gibson042 · 2025-05-08T20:19:34Z

In accord with #960 (comment) and TG2 discussion, this will be exposed as a string-returning variants getter to align with the other subtag-based properties (language, baseName, script, region, calendar, etc.).

Fixes tc39#900

….variants

Ref tc39/ecma402#960

gibson042 · 2025-05-29T21:42:22Z

This reached consensus in TC39 plenary.

Ref tc39/ecma402#960

anba · 2025-05-29T22:56:36Z

spec/locale.html

-        1. Let _variants_ be GetLocaleVariants(_baseName_).
+        1. Let _variants_ be ? GetOption(_options_, *"variants"*, ~string~, ~empty~, GetLocaleVariants(_baseName_)).
+        1. If _variants_ is not *undefined*, then
+          1. If _variants_ cannot be matched by the <code>unicode_variant_subtag</code> Unicode locale nonterminal, throw a *RangeError* exception.


unicode_variant_subtag matches a single variant subtag. That means new Intl.Locale("kl-tunumiit-kleinsch") will now always throw a RangeError. Probably needs StringSplitToList(variants, "-") and then check unicode_variant_subtag on all elements of the returned List.

Ugh, nice catch. Fix: #1007.

…nst a subtag sequence Fixes tc39#960

Ref tc39/ecma402#960

sffc · 2025-06-14T01:16:09Z

TG2 discussion in May 2025: https://github.com/tc39/ecma402/blob/main/meetings/notes-2025-05-08.md#normative-add-localeprototypegetvariants-960

https://bugs.webkit.org/show_bug.cgi?id=294755 Reviewed by NOBODY (OOPS!). tc39/ecma402#960 added `Intl.Locale.prototype.variants` to the ECMAScript specification. The test262 test suite has also been updated [1]. This patch implements `Intl.Locale.prototype.variants` for JSC. [1]: tc39/test262#4474 * JSTests/stress/intl-locale-prototype-variants.js: Added. (shouldBe): (shouldThrow): * JSTests/test262/expectations.yaml: * Source/JavaScriptCore/runtime/CommonIdentifiers.h: * Source/JavaScriptCore/runtime/IntlLocale.cpp: (JSC::LocaleIDBuilder::overrideLanguageScriptRegionVariants): (JSC::IntlLocale::initializeLocale): (JSC::IntlLocale::variants): (JSC::LocaleIDBuilder::overrideLanguageScriptRegion): Deleted. * Source/JavaScriptCore/runtime/IntlLocale.h: * Source/JavaScriptCore/runtime/IntlLocalePrototype.cpp: (JSC::JSC_DEFINE_CUSTOM_GETTER):

https://bugs.webkit.org/show_bug.cgi?id=294755 Reviewed by Yusuke Suzuki. tc39/ecma402#960 added `Intl.Locale.prototype.variants` to the ECMAScript specification. The test262 test suite has also been updated [1]. This patch implements `Intl.Locale.prototype.variants` for JSC. [1]: tc39/test262#4474 * JSTests/stress/intl-locale-prototype-variants.js: Added. (shouldBe): (shouldThrow): * JSTests/test262/expectations.yaml: * Source/JavaScriptCore/runtime/CommonIdentifiers.h: * Source/JavaScriptCore/runtime/IntlLocale.cpp: (JSC::LocaleIDBuilder::overrideLanguageScriptRegionVariants): (JSC::IntlLocale::initializeLocale): (JSC::IntlLocale::variants): (JSC::LocaleIDBuilder::overrideLanguageScriptRegion): Deleted. * Source/JavaScriptCore/runtime/IntlLocale.h: * Source/JavaScriptCore/runtime/IntlLocalePrototype.cpp: (JSC::JSC_DEFINE_CUSTOM_GETTER): Canonical link: https://commits.webkit.org/296467@main

https://tc39.es/ecma402/#sec-Intl.Locale.prototype.variants Added to the spec by tc39/ecma402#960 Test code added in tc39/test262#4474 feature https://chromestatus.com/feature/4709921706868736 I2P https://groups.google.com/a/chromium.org/g/blink-dev/c/NCT4pPJ_Uz8/m/G62K-m6CAgAJ Bug: 450083673 Change-Id: I49a4af9f9e75a18efb3b67f546f971d4c24e0bb0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7018878 Reviewed-by: Leszek Swirski <[email protected]> Reviewed-by: Olivier Flückiger <[email protected]> Commit-Queue: Frank Tang <[email protected]> Cr-Commit-Position: refs/heads/main@{#103188}

https://tc39.es/ecma402/#sec-Intl.Locale.prototype.variants Added to the spec by tc39/ecma402#960 Test code added in tc39/test262#4474 feature https://chromestatus.com/feature/4709921706868736 I4DT https://groups.google.com/a/chromium.org/g/blink-dev/c/i6QEHcH_fiI/m/4xUyZbSvAAAJ Bug: 450083673 Change-Id: I987b3066726323550d098222e50da999c145495c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7064530 Commit-Queue: Frank Tang <[email protected]> Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]> Cr-Commit-Position: refs/heads/main@{#103233}

sffc · 2025-11-06T00:22:53Z

TG1 notes from 2025 May: https://github.com/tc39/notes/blob/main/meetings/2025-05/may-28.md#normative-add-intllocaleprototypevariants-ecma402960

gibson042 added enhancement needs tests c: locale Component: locale identifiers normative needs review needs consensus labels Feb 14, 2025

sffc added this to ECMA-402 Meeting Topics Mar 3, 2025

sffc moved this to Priority Issues in ECMA-402 Meeting Topics Mar 3, 2025

FrankYFTang reviewed Mar 6, 2025

View reviewed changes

eemeli requested changes May 8, 2025

View reviewed changes

spec/locale.html Outdated Show resolved Hide resolved

eemeli approved these changes May 8, 2025

View reviewed changes

gibson042 added 2 commits May 8, 2025 16:19

Normative: Add Locale.prototype.getVariants

49e60ec

Fixes tc39#900

Normative: Replace Locale.prototype.getVariants with Locale.prototype…

a606142

….variants

gibson042 force-pushed the gh-900-locale-getvariants branch from c001a65 to a606142 Compare May 8, 2025 20:21

Normative: Support setting variants by Intl.Locale constructor options

0df0264

gibson042 added a commit to gibson042/test262 that referenced this pull request May 8, 2025

Add tests for Intl.Locale.prototype.variants

ab9c77e

Ref tc39/ecma402#960

gibson042 mentioned this pull request May 8, 2025

Add tests for Intl.Locale.prototype.variants tc39/test262#4474

Merged

gibson042 changed the title ~~Normative: Add Locale.prototype.getVariants~~ Normative: Add Intl.Locale.prototype.getVariants May 9, 2025

gibson042 changed the title ~~Normative: Add Intl.Locale.prototype.getVariants~~ Normative: Add Intl.Locale.prototype.variants May 9, 2025

ryzokuken approved these changes May 13, 2025

View reviewed changes

ryzokuken added has consensus Has consensus from TC39-TG2 has tests and removed needs tests needs review labels May 13, 2025

gibson042 merged commit e8c995a into tc39:main May 29, 2025
2 checks passed

gibson042 added a commit to gibson042/test262 that referenced this pull request May 29, 2025

Add tests for Intl.Locale.prototype.variants

b6fd532

Ref tc39/ecma402#960

anba reviewed May 29, 2025

View reviewed changes

sffc mentioned this pull request May 30, 2025

Variants getter should not throw on multiple variants #1006

Closed

gibson042 added a commit to gibson042/ecma402 that referenced this pull request May 30, 2025

Editorial: Fix incorrect application of unicode_variant_subtag agai…

b3ab8c9

…nst a subtag sequence Fixes tc39#960

gibson042 mentioned this pull request May 30, 2025

Editorial: Fix incorrect validation of variants for Intl.Locale construction #1007

Merged

Ms2ger pushed a commit to gibson042/test262 that referenced this pull request Jun 4, 2025

Add tests for Intl.Locale.prototype.variants

9da80fa

Ref tc39/ecma402#960

Ms2ger pushed a commit to tc39/test262 that referenced this pull request Jun 4, 2025

Add tests for Intl.Locale.prototype.variants

c2bfc5b

Ref tc39/ecma402#960

linusg mentioned this pull request Jun 14, 2025

FFI for locale variants unicode-org/icu4x#6671

Open

sosukesuzuki mentioned this pull request Jun 20, 2025

[JSC] Implement Intl.Locale.prototype.variants getter WebKit/WebKit#46992

Merged

sffc moved this from Priority Issues to Previously Discussed in ECMA-402 Meeting Topics Jul 16, 2025

Normative: Add Intl.Locale.prototype.variants #960

Normative: Add Intl.Locale.prototype.variants #960

Uh oh!

Conversation

gibson042 commented Feb 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

FrankYFTang Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

gibson042 Mar 6, 2025

Choose a reason for hiding this comment

Uh oh!

FrankYFTang commented Mar 6, 2025

Uh oh!

gibson042 commented Mar 6, 2025

Uh oh!

sffc commented Mar 10, 2025

Uh oh!

sffc commented Apr 3, 2025

Uh oh!

Uh oh!

gibson042 commented May 8, 2025

Uh oh!

gibson042 commented May 29, 2025

Uh oh!

Uh oh!

anba May 29, 2025

Choose a reason for hiding this comment

Uh oh!

sffc May 30, 2025

Choose a reason for hiding this comment

Uh oh!

gibson042 May 30, 2025

Choose a reason for hiding this comment

Uh oh!

sffc commented Jun 14, 2025

Uh oh!

sffc commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gibson042 commented Feb 14, 2025 •

edited

Loading