Normative: In PluralRules, set compactDisplay only if notation is "compact" #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address #1031 This is necessary because 1. compatDisplay does not make sense if notation is not compact 2. costly to implement resolvedOptions() w/o in v8 since currently v8 depends on icu's skeleton to get the compactDisplay and there are no defined value for the case while notation is not compact
FrankYFTang
changed the title
sffc
changed the title
ryzokuken
approved these changes
Nov 4, 2025
Member
ryzokuken
left a comment
ryzokuken
left a comment
There was a problem hiding this comment.
LGTM apart from this one comment
|
@anba This makes sense to me, but it would be great if you could have a quick look as well :) |
anba
approved these changes
Nov 6, 2025
Contributor
The change looks good to me! |
ryzokuken
added
normative
needs consensus
has consensus
Contributor
Author
|
reach consensus in TC39 TG1 2025-11-18 10:51 AM JST |
Contributor
Author
|
Please merge. thanks |
Contributor
Author
|
@ben-allen please merge. I have not right to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1031
NumberFormat does this for a while but the recently added compactDisply for PluralRule is not
This fix is necessary because