Skip to content

Conversation

@jhnaldo
Copy link
Contributor

@jhnaldo jhnaldo commented Nov 13, 2025

This PR supports the checking of newly introduced phrases using ESMeta related to the following issue:

The main feature is developed in the following PR:

You can see the test results of this check as follows:

PR Author Name Added/Modified Lines Unknown Step Unknown Type
#3655 Kevin Gibbons test1 406 6 4
#3660 mobius29 test2 1 0 0
#3691 Kevin Gibbons test3 1 0 0
#3513 Richard Gibson test4 14 2 1
#3595 Aapo Alasuutari test5 3 0 0
#3608 Michael Ficarra test6 1 0 0
#3613 Nicolò Ribaudo test7 2 0 0
#3613 Jordan Harband test8 1 0 0
#3619 Richard Gibson test9 7 0 0
#3620 André Bargull test10 326 0 0
#3664 mobius29 test11 2 0 0
#3687 Nicolò Ribaudo test12 5 0 0
#3694 YAMAMOTO Yuji test13 1 0 0

Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

Copy link
Member

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than switching to a sha rather than a mutable tag.

@jhnaldo
Copy link
Contributor Author

jhnaldo commented Dec 16, 2025

I updated this PR to use SHA rather than a mutable tag.

@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Dec 16, 2025
@ljharb ljharb merged commit bfd5f45 into tc39:main Dec 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta ready to merge Editors believe this PR needs no further reviews, and is ready to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants